From: Morris Ku <saumah@gmail.com>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, morris_ku@sunix.com,
Morris Ku <saumah@gmail.com>
Subject: [PATCH4/4] Add support for SUNIX Multi-I/O board
Date: Mon, 8 Apr 2019 19:16:53 +0800 [thread overview]
Message-ID: <20190408111653.4260-1-saumah@gmail.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=Y, Size: 2360 bytes --]
Hi, Lee,
Thanks for review, my replies are inline:
Signed-off-by: Morris Ku <saumah@gmail.com>
---
+
+On 03 Apr 2019, Lee Jones wrote:
+
+> >Please do not drop the list from your recipients.
+
+>On Tue, 02 Apr 2019, Morris Ku 古文俊 wrote:
+
+> Hello , Lee ,
+>
+>
+> Sunix multi-io card is a composite device,
+> contains serial and parallel port , before we
+> trying to place the driver in the /drivers/char,
+> but maintainer suggests go to /driver/mfd,so we move to here.
+> this driver is special,it supports more than one interface,
+> so we combine to a single driver.
+
+> The MFD subsystem is designed to register child devices. MFD drivers
+> do not contain any true functionality themselves. If this device does
+> multiple things, you can split the functionality into their relevant
+> subsystems and register each of them from here.
+
+> There are 10's of examples available. Please take a look around some
+> of the existing drivers to see how their functionality is split.
+
Could you please clearly tell me the name of driver for reference.
+
+> On Tue, 19 Mar 2019, Morris Ku wrote:
+>
+> > Driver for SUNIX Multi-I/O card.Based on parport_pc.c, ppdev.c
+> > and lp.c by Linus Torvalds, Theodore Ts'o.
+>
+> Parallel port drivers should live in 'drivers/parport' and
+> 'drivers/char'. LP drivers should live in 'drivers/char'.
+>
+> Please them there.
+>
+> > Signed-off-by: Morris Ku <saumah@gmail.com>
+> > ---
+> > mfd/sunix/snx_ieee1284.c | 144 +++++++
+> > mfd/sunix/snx_ieee1284_ops.c | 258 +++++++++++++
+> > mfd/sunix/snx_lp.c | 717 +++++++++++++++++++++++++++++++++++
+> > mfd/sunix/snx_lp.h | 119 ++++++
+> > mfd/sunix/snx_parallel.c | 397 +++++++++++++++++++
+> > mfd/sunix/snx_ppdev.c | 454 ++++++++++++++++++++++
+> > mfd/sunix/snx_ppdev.h | 15 +
+> > mfd/sunix/snx_share.c | 629 ++++++++++++++++++++++++++++++
+> > 8 files changed, 2733 insertions(+)
+> > create mode 100644 mfd/sunix/snx_ieee1284.c
+> > create mode 100644 mfd/sunix/snx_ieee1284_ops.c
+> > create mode 100644 mfd/sunix/snx_lp.c
+> > create mode 100644 mfd/sunix/snx_lp.h
+> > create mode 100644 mfd/sunix/snx_parallel.c
+> > create mode 100644 mfd/sunix/snx_ppdev.c
+> > create mode 100644 mfd/sunix/snx_ppdev.h
+> > create mode 100644 mfd/sunix/snx_share.c
+>
+
--
2.17.1
next reply other threads:[~2019-04-08 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 11:16 Morris Ku [this message]
2019-04-08 16:51 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408111653.4260-1-saumah@gmail.com \
--to=saumah@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morris_ku@sunix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®