From: Davidlohr Bueso <dave@stgolabs.net>
To: Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>,
Stanislav Kinsbursky <skinsbursky@parallels.com>,
Manfred Spraul <manfred@colorfullife.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/ipc: Fix msgque compiler warnings
Date: Mon, 8 Apr 2019 13:01:41 -0700 [thread overview]
Message-ID: <20190408200141.uusxqlqly6tab6h7@linux-r8p5> (raw)
In-Reply-To: <20190408171344.GA22803@beast>
On Mon, 08 Apr 2019, Kees Cook wrote:
>This fixes the various compiler warnings when building the msgque
>selftest. The primary change is using sys/msg.h instead of linux/msg.h
>directly to gain the API declarations.
>
>Fixes: 3a665531a3b7 ("selftests: IPC message queue copy feature test")
>Signed-off-by: Kees Cook <keescook@chromium.org>
(Not really related to this patch)
Given that the selftest/ipc/ only consists of this test, I wonder if
the test should just be moved to ltp, where the ipc tests are a lot
more complete and robust -- and which I've been using for years for
basic testing code changes.
Don't get me wrong, I'm all for having ipc tests in the kernel, but it
seems rather impractical to have them in both places considering the
relevance of ltp in the community and how long they have existed there.
I'm also speaking on the basis that by ipc we are referring only to
sysv and posix flavors.
Thanks,
Davidlohr
next prev parent reply other threads:[~2019-04-08 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 17:13 Kees Cook
2019-04-08 20:01 ` Davidlohr Bueso [this message]
2019-04-19 19:10 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408200141.uusxqlqly6tab6h7@linux-r8p5 \
--to=dave@stgolabs.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=shuah@kernel.org \
--cc=skinsbursky@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®