From: Qian Cai <cai@lca.pw>
To: dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org
Cc: catalin.marinas@arm.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org,
Qian Cai <cai@lca.pw>
Subject: [PATCH] x86/mm/mem_encrypt: fix a crash with kmemleak_scan
Date: Tue, 9 Apr 2019 00:05:02 -0400 [thread overview]
Message-ID: <20190409040502.55361-1-cai@lca.pw> (raw)
The first kmemleak_scan() after boot would trigger a crash below because
kernel_init
free_initmem
mem_encrypt_free_decrypted_mem
free_init_pages
unmapped some memory inside the .bss.
BUG: unable to handle kernel paging request at ffffffffbd402000
CPU: 12 PID: 325 Comm: kmemleak Not tainted 5.1.0-rc4+ #4
RIP: 0010:scan_block+0x58/0x160
Call Trace:
scan_gray_list+0x1d9/0x280
kmemleak_scan+0x485/0xad0
kmemleak_scan_thread+0x9f/0xc4
kthread+0x1d2/0x1f0
ret_from_fork+0x35/0x40
Signed-off-by: Qian Cai <cai@lca.pw>
---
arch/x86/mm/mem_encrypt.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
index 385afa2b9e17..614ab156024f 100644
--- a/arch/x86/mm/mem_encrypt.c
+++ b/arch/x86/mm/mem_encrypt.c
@@ -18,6 +18,7 @@
#include <linux/dma-direct.h>
#include <linux/swiotlb.h>
#include <linux/mem_encrypt.h>
+#include <linux/kmemleak.h>
#include <asm/tlbflush.h>
#include <asm/fixmap.h>
@@ -369,6 +370,11 @@ void __init mem_encrypt_free_decrypted_mem(void)
}
}
+ /*
+ * Inform kmemleak about the hole in the .bss section since the
+ * corresponding pages will be unmapped with DEBUG_PAGEALLOC=y.
+ */
+ kmemleak_free_part((void *)vaddr, vaddr_end - vaddr);
free_init_pages("unused decrypted", vaddr, vaddr_end);
}
--
2.17.2 (Apple Git-113)
next reply other threads:[~2019-04-09 4:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 4:05 Qian Cai [this message]
2019-04-16 13:44 ` Catalin Marinas
2019-04-16 17:11 ` Borislav Petkov
2019-04-17 0:38 ` Qian Cai
2019-04-18 7:45 ` Borislav Petkov
2019-04-18 9:50 ` Catalin Marinas
2019-04-23 13:25 ` Borislav Petkov
2019-04-23 14:02 ` Catalin Marinas
2019-04-23 15:17 ` Borislav Petkov
2019-04-23 14:16 ` Qian Cai
2019-04-23 15:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409040502.55361-1-cai@lca.pw \
--to=cai@lca.pw \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®