From: Mark Brown <broonie@kernel.org>
To: Pengcheng Li <lipengcheng8@huawei.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
john.stultz@linaro.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com,
kongfei@hisilicon.com, liyuequan@hisilicon.com,
cash.qianli@hisilicon.com, huangli295@hisilicon.com,
hantanglei@huawei.com, wangyoulin1@hisilicon.com,
ninggaoyu@hisilicon.com, xuwei5@huawei.com
Subject: Re: [PATCH 2/3] ASoC: add hikey960-i2s DT bindings
Date: Wed, 10 Apr 2019 12:10:32 +0100 [thread overview]
Message-ID: <20190410111032.GJ6106@sirena.org.uk> (raw)
In-Reply-To: <1551362261-99422-1-git-send-email-lipengcheng8@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On Thu, Feb 28, 2019 at 09:57:41PM +0800, Pengcheng Li wrote:
> +Required properties:
> +
> +- compatible: should be one of the following:
> + - "hisilicon,hi3660-i2s-1.0"
> +- reg: physical base address of the i2s controller unit and length of
> + memory mapped region.
This binding is inaccurate for the code as it requires two memory
regions, one for the IP and one for the system controller. However as I
said in the review of the driver you should probably be using the
standard syscon binding for the system controller.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-04-10 11:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 13:57 Pengcheng Li
2019-04-10 11:10 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410111032.GJ6106@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cash.qianli@hisilicon.com \
--cc=hantanglei@huawei.com \
--cc=huangli295@hisilicon.com \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lipengcheng8@huawei.com \
--cc=liyuequan@hisilicon.com \
--cc=ninggaoyu@hisilicon.com \
--cc=perex@perex.cz \
--cc=suzhuangluan@hisilicon.com \
--cc=tiwai@suse.com \
--cc=wangyoulin1@hisilicon.com \
--cc=xuwei5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®