From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341D6C10F11 for ; Wed, 10 Apr 2019 21:49:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4B4C20820 for ; Wed, 10 Apr 2019 21:49:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iZUPsVjd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbfDJVtt (ORCPT ); Wed, 10 Apr 2019 17:49:49 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:50551 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfDJVtt (ORCPT ); Wed, 10 Apr 2019 17:49:49 -0400 Received: by mail-it1-f196.google.com with SMTP id q14so6169101itk.0 for ; Wed, 10 Apr 2019 14:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e868xr/naBP8Ia4Ix3OMgJwwrPy0huba5mSynPBdj0E=; b=iZUPsVjd5JdNUfgTDd2wbUA5JQmEOyUW7HVciQvDMLSPwwr528b4pnnH8BFvvZi1lk /WqmZFF9QAvRWTe0JwdZxj/yu1pqvL1I/hR1XbgwQ9oCKQ/SwlLSE1iqmzv0sFPjdvR1 0PlNcDm7kR7MkY9tfmj1O3cjPI56+9vleIlHE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e868xr/naBP8Ia4Ix3OMgJwwrPy0huba5mSynPBdj0E=; b=MGSlhwPX9q7idow1YFxcmQk/tcTjjVVTtNs1y8c0iPvWQLDR8DUSYscIfNbLz1LF5T Eyqz8alIF2EknVHAqJLZFyU22KKZTa1QfswUmrkgRHqjayAzOEXFT477Konlt1yUOXOC bvDqZ5sB5cCevVmD9MdesYrLdZ7WmG5jg6jYxhtouPy78UPSW5Tbas84w1A4aevV2G20 8aR2PfV4RsUt8HyJkMTUih+c2S923PjBPvU6R40wyfloYfOWFEvaUY2eSArI/YCRPhy+ eXTV4f32QMBXE/yIKMrLXmgG22temiixZKfwUgjPOOB7S6JrUngOumHHex5AxkJYITIJ 8FRg== X-Gm-Message-State: APjAAAVoEHNogULhd+sWTTdnoDIjSOIqBD+W51wUJkixWN3gMUFU8aEp QNpY5KJIyGMKaYl2aye94zeqvA== X-Google-Smtp-Source: APXvYqzsUYDpDIN9RSTxzuotJjDeGJLXvngBHRs3WY1txsRbMzKKPt5VgDplKXzMRsWAEYPIFaAOOQ== X-Received: by 2002:a02:924d:: with SMTP id y13mr30220161jag.24.1554932988239; Wed, 10 Apr 2019 14:49:48 -0700 (PDT) Received: from ncrews2.bld.corp.google.com ([2620:15c:183:200:cb43:2cd4:65f5:5c84]) by smtp.gmail.com with ESMTPSA id u66sm14626610ioe.74.2019.04.10.14.49.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Apr 2019 14:49:47 -0700 (PDT) From: Nick Crews To: enric.balletbo@collabora.com, bleung@chromium.org Cc: linux-kernel@vger.kernel.org, dlaurie@chromium.org, derat@google.com, groeck@google.com, dtor@google.com, sjg@chromium.org, alevkoy@chromium.org, keithshort@chromium.org, Nick Crews Subject: [PATCH v2] platform/chrome: wilco_ec: Add h1_gpio status to debugfs Date: Wed, 10 Apr 2019 15:49:41 -0600 Message-Id: <20190410214941.45554-1-ncrews@chromium.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As part of Chrome OS's FAFT (Fully Automated Firmware Testing) tests, we need to ensure that the H1 chip is properly setting some GPIO lines. The h1_gpio attribute exposes the state of the lines: - ENTRY_TO_FACT_MODE in BIT(0) - SPI_CHROME_SEL in BIT(1) There are two reasons that I am exposing this in debugfs, and not as a GPIO: 1. This is only useful for testing, so end users shouldn't ever care about this. In fact, if it passes the tests, then the value of h1_gpio will always be 2, so it would be really uninteresting for users. 2. This GPIO is not connected to, controlled by, or really even related to the AP. The GPIO runs between the EC and the H1 security chip. Changes in v2: - Zero out the unused fields in the request. - Format result as "%02x\n" instead of as a decimal. Signed-off-by: Nick Crews --- drivers/platform/chrome/wilco_ec/debugfs.c | 64 +++++++++++++++++++++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c b/drivers/platform/chrome/wilco_ec/debugfs.c index 17c4c9068aaf..e1d9a6b73be9 100644 --- a/drivers/platform/chrome/wilco_ec/debugfs.c +++ b/drivers/platform/chrome/wilco_ec/debugfs.c @@ -4,7 +4,7 @@ * * Copyright 2019 Google LLC * - * There is only one attribute used for debugging, called raw. + * The raw attribute is very useful for EC debugging. * You can write a hexadecimal sentence to raw, and that series of bytes * will be sent to the EC. Then, you can read the bytes of response * by reading from raw. @@ -30,6 +30,16 @@ * Note that the first 32 bytes of the received MBOX[] will be printed, * even if some of the data is junk. It is up to you to know how many of * the first bytes of data are the actual response. + * + * There is also another debugfs attribute, called h1_gpio. + * As part of Chrome OS's FAFT (Fully Automated Firmware Testing) + * tests, we need to ensure that the H1 chip is properly setting + * some GPIO lines. The h1_gpio attribute exposes the state + * of the lines: + * - ENTRY_TO_FACT_MODE in BIT(0) + * - SPI_CHROME_SEL in BIT(1) + + * Output will be "0\n", "1\n", "2\n", or "3\n". */ #include @@ -189,6 +199,56 @@ static const struct file_operations fops_raw = { .llseek = no_llseek, }; +#define CMD_KB_CHROME 0x88 +#define SUB_CMD_H1_GPIO 0x0A + +struct h1_gpio_status_request { + u8 cmd; /* Always CMD_KB_CHROME */ + u8 reserved; + u8 sub_cmd; /* Always SUB_CMD_H1_GPIO */ +} __packed; + +struct hi_gpio_status_response { + u8 status; /* 0 if allowed */ + u8 val; /* BIT(0)=ENTRY_TO_FACT_MODE, BIT(1)=SPI_CHROME_SEL */ +} __packed; + +static ssize_t h1_gpio_read(struct file *file, char __user *user_buf, + size_t count, loff_t *ppos) +{ + struct h1_gpio_status_request rq; + struct hi_gpio_status_response rs; + struct wilco_ec_message msg; + char buf[4]; + int ret; + + memset(&rq, 0, sizeof(rq)); + rq.cmd = CMD_KB_CHROME; + rq.sub_cmd = SUB_CMD_H1_GPIO; + + memset(&msg, 0, sizeof(msg)); + msg.type = WILCO_EC_MSG_LEGACY; + msg.request_data = &rq; + msg.request_size = sizeof(rq); + msg.response_data = &rs; + msg.response_size = sizeof(rs); + ret = wilco_ec_mailbox(debug_info->ec, &msg); + if (ret < 0) + return ret; + if (rs.status) + return -EIO; + + sprintf(buf, "%02x\n", rs.val); + + return simple_read_from_buffer(user_buf, count, ppos, buf, sizeof(buf)); +} + +static const struct file_operations fops_h1_gpio = { + .owner = THIS_MODULE, + .read = h1_gpio_read, + .llseek = no_llseek, +}; + /** * wilco_ec_debugfs_probe() - Create the debugfs node * @pdev: The platform device, probably created in core.c @@ -210,6 +270,8 @@ static int wilco_ec_debugfs_probe(struct platform_device *pdev) if (!debug_info->dir) return 0; debugfs_create_file("raw", 0644, debug_info->dir, NULL, &fops_raw); + debugfs_create_file("h1_gpio", 0444, debug_info->dir, NULL, + &fops_h1_gpio); return 0; } -- 2.20.1