From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE65C10F11 for ; Thu, 11 Apr 2019 01:13:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F72C20818 for ; Thu, 11 Apr 2019 01:13:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbfDKBNn (ORCPT ); Wed, 10 Apr 2019 21:13:43 -0400 Received: from mga12.intel.com ([192.55.52.136]:18751 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfDKBNn (ORCPT ); Wed, 10 Apr 2019 21:13:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 18:13:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,335,1549958400"; d="scan'208";a="160607395" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmsmga004.fm.intel.com with ESMTP; 10 Apr 2019 18:13:42 -0700 Date: Wed, 10 Apr 2019 18:12:31 -0700 From: Ricardo Neri To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Ashok Raj , Andi Kleen , "Ravi V. Shankar" , x86@kernel.org, linux-kernel@vger.kernel.org, Ricardo Neri , "H. Peter Anvin" , Tony Luck , Clemens Ladisch , Arnd Bergmann , Philippe Ombredanne , Kate Stewart , "Rafael J. Wysocki" , Mimi Zohar , Jan Kiszka , Nick Desaulniers , Masahiro Yamada , Nayna Jain Subject: Re: [RFC PATCH v2 12/14] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI Message-ID: <20190411011231.GA9936@ranerica-svr.sc.intel.com> References: <1551283518-18922-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <1551283518-18922-13-git-send-email-ricardo.neri-calderon@linux.intel.com> <20190409112817.GT4038@hirez.programming.kicks-ass.net> <20190410011957.GC10062@ranerica-svr.sc.intel.com> <20190410070152.GV11158@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410070152.GV11158@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 09:01:52AM +0200, Peter Zijlstra wrote: > On Tue, Apr 09, 2019 at 06:19:57PM -0700, Ricardo Neri wrote: > > On Tue, Apr 09, 2019 at 01:28:17PM +0200, Peter Zijlstra wrote: > > > > @@ -147,6 +161,14 @@ static void set_periodic(struct hpet_hld_data *hdata) > > > > */ > > > > static bool is_hpet_wdt_interrupt(struct hpet_hld_data *hdata) > > > > { > > > > + if (smp_processor_id() == hdata->handling_cpu) { > > > > + unsigned long tsc_curr; > > > > > > TSC is u64 > > > > In x86_64, isn't u64 an unsigned long? Do you mean to consider the > > 32-bit case? > > Unless none of this code is available for x86_32, you pretty much have > to consider 32bit. > > But even then, using u64 for 64bit values is the right thing. OK, I'll implement this change. Thanks and BR, Ricardo