From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99AC4C10F11 for ; Thu, 11 Apr 2019 03:02:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6306020818 for ; Thu, 11 Apr 2019 03:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbfDKDCF (ORCPT ); Wed, 10 Apr 2019 23:02:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbfDKDCE (ORCPT ); Wed, 10 Apr 2019 23:02:04 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 871FCDA314; Thu, 11 Apr 2019 03:02:04 +0000 (UTC) Received: from treble (ovpn-120-231.rdu2.redhat.com [10.10.120.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1711F1001E71; Thu, 11 Apr 2019 03:02:03 +0000 (UTC) Date: Wed, 10 Apr 2019 22:02:01 -0500 From: Josh Poimboeuf To: Thomas Gleixner Cc: LKML , x86@kernel.org, Andy Lutomirski , Steven Rostedt , Alexander Potapenko , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski Subject: Re: [RFC patch 28/41] dma/debug: Simplify stracktrace retrieval Message-ID: <20190411030201.uko3njal44w2ea4b@treble> References: <20190410102754.387743324@linutronix.de> <20190410103646.130022106@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190410103646.130022106@linutronix.de> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 11 Apr 2019 03:02:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 12:28:22PM +0200, Thomas Gleixner wrote: > Replace the indirection through struct stack_trace with an invocation of > the storage array based interface. > > Signed-off-by: Thomas Gleixner > Cc: iommu@lists.linux-foundation.org > Cc: Robin Murphy > Cc: Christoph Hellwig > Cc: Marek Szyprowski > --- > kernel/dma/debug.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > --- a/kernel/dma/debug.c > +++ b/kernel/dma/debug.c > @@ -89,8 +89,8 @@ struct dma_debug_entry { > int sg_mapped_ents; > enum map_err_types map_err_type; > #ifdef CONFIG_STACKTRACE > - struct stack_trace stacktrace; > - unsigned long st_entries[DMA_DEBUG_STACKTRACE_ENTRIES]; > + unsigned int st_len; > + unsigned long st_entries[DMA_DEBUG_STACKTRACE_ENTRIES]; nit: st_entries isn't very readable. Thanks to the magic of compilers, the characters are free, so why not call them "stacktrace_entries" and "stacktrace_len". -- Josh