From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EF14C282CE for ; Thu, 11 Apr 2019 13:00:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77C112133D for ; Thu, 11 Apr 2019 13:00:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726805AbfDKNAH (ORCPT ); Thu, 11 Apr 2019 09:00:07 -0400 Received: from 178.115.242.59.static.drei.at ([178.115.242.59]:38495 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfDKNAG (ORCPT ); Thu, 11 Apr 2019 09:00:06 -0400 Received: by mail.osadl.at (Postfix, from userid 1001) id 97ED65C2F68; Thu, 11 Apr 2019 14:59:18 +0200 (CEST) Date: Thu, 11 Apr 2019 14:59:18 +0200 From: Nicholas Mc Guire To: Joe Perches Cc: Stephen Boyd , Nicholas Mc Guire , Ulf Hansson , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] clk: ux500: add range to usleep_range Message-ID: <20190411125918.GB8986@osadl.at> References: <1554606804-29453-1-git-send-email-hofrat@opentech.at> <155493683173.20095.12913107010666279046@swboyd.mtv.corp.google.com> <20190411025602.GB5487@osadl.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 11, 2019 at 04:51:25AM -0700, Joe Perches wrote: > On Thu, 2019-04-11 at 04:56 +0200, Nicholas Mc Guire wrote: > > On Wed, Apr 10, 2019 at 03:53:51PM -0700, Stephen Boyd wrote: > > > Quoting Nicholas Mc Guire (2019-04-06 20:13:24) > > > > Providing a range for usleep_range() allows the hrtimer subsystem to > > > > coalesce timers - the delay is runtime configurable so a factor 2 > > > > is taken to provide the range. > > > > > > > > Signed-off-by: Nicholas Mc Guire > > > > --- > > > > > > I think this driver is in maintenance mode. I'll wait for Ulf to ack or > > > review this change before applying. > > > > > > > diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c > > > > index 7c0403b..a1fa3fb 100644 > > > > --- a/drivers/clk/ux500/clk-sysctrl.c > > > > +++ b/drivers/clk/ux500/clk-sysctrl.c > > > > @@ -42,7 +42,7 @@ static int clk_sysctrl_prepare(struct clk_hw *hw) > > > > clk->reg_bits[0]); > > > > > > > > if (!ret && clk->enable_delay_us) > > > > - usleep_range(clk->enable_delay_us, clk->enable_delay_us); > > > > + usleep_range(clk->enable_delay_us, clk->enable_delay_us*2); > > > > > > Please add space around that multiply. > > > > > I can do that but it does not seem common and also checkpatch > > did not complain about this - now a simple grep -re "\*10" on the > > kernel shows that it seems more common not to use spaces around * > > that to use them. > > Not really > > $ git grep -P '\*\s*10' | grep -oh -P '\*\s*10' | \ > sort | uniq -c | sort -rn | head > 11800 * 10 > 1705 *10 > 179 * 10 > 74 * 10 > 67 * 10 > 20 * 10 > 20 * 10 > 14 * 10 > 14 * 10 > 12 * 10 yup - my bad - If you restrict it to code lines - its 1:10 not quite sure how I got the first numbers - sloppy check. hofrat@debian:~/git/linux-next$ grep -re '.*\*\s*10.*;$' * | grep -oh '\*\s*10' | sort | uniq -c | sort -nr | more 8568 * 10 860 *10 Anyway - is there a reason checkpatch will not flag this ? thx! hofrat > > > Greping specifically for cases using usleep_range() > > (not that many) it seems more or less evenly devided between space > > and no space - so the concern is overlooking that factor 2 ? > > > > thx! > > hofrat >