From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF6FC10F13 for ; Thu, 11 Apr 2019 15:50:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 601CF20818 for ; Thu, 11 Apr 2019 15:50:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726771AbfDKPua (ORCPT ); Thu, 11 Apr 2019 11:50:30 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:60441 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbfDKPu3 (ORCPT ); Thu, 11 Apr 2019 11:50:29 -0400 X-Originating-IP: 90.88.18.121 Received: from localhost (aaubervilliers-681-1-63-121.w90-88.abo.wanadoo.fr [90.88.18.121]) (Authenticated sender: maxime.ripard@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 2EC812000A; Thu, 11 Apr 2019 15:50:25 +0000 (UTC) Date: Thu, 11 Apr 2019 17:50:25 +0200 From: Maxime Ripard To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jagan Teki , devicetree , linux-kernel , linux-arm-kernel , dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6 Message-ID: <20190411155025.d5hmbw2jzhp3wyuq@flea> References: <20190411105720.32357-1-peron.clem@gmail.com> <2797515.ZAugZ1JPiN@jernej-laptop> <20190411152752.qlabx7heh74dy2ao@flea> <5149757.GgN2G91tE9@jernej-laptop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ughvejlzbua5n4db" Content-Disposition: inline In-Reply-To: <5149757.GgN2G91tE9@jernej-laptop> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ughvejlzbua5n4db Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 11, 2019 at 05:42:56PM +0200, Jernej =C5=A0krabec wrote: > Dne =C4=8Detrtek, 11. april 2019 ob 17:27:52 CEST je Maxime Ripard napisa= l(a): > > On Thu, Apr 11, 2019 at 05:23:25PM +0200, Jernej =C5=A0krabec wrote: > > > Dne =C4=8Detrtek, 11. april 2019 ob 17:20:04 CEST je Cl=C3=A9ment P= =C3=A9ron napisal(a): > > > > Hi, > > > > > > > > On Thu, 11 Apr 2019 at 17:05, Jernej =C5=A0krabec > > > > > > wrote: > > > > > Dne =C4=8Detrtek, 11. april 2019 ob 12:57:16 CEST je Cl=C3=A9ment= P=C3=A9ron > napisal(a): > > > > > > Add the mali gpu node to the H6 device-tree. > > > > > > > > > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > > > > --- > > > > > > > > > > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++= ++ > > > > > > 1 file changed, 14 insertions(+) > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > > > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index > > > > > > e0dc4a05c1ba..196753110434 100644 > > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > > > > @@ -157,6 +157,20 @@ > > > > > > > > > > > > allwinner,sram =3D <&ve_sram 1>; > > > > > > > > > > > > }; > > > > > > > > > > > > + gpu: gpu@1800000 { > > > > > > + compatible =3D "allwinner,sun50i-h6-mali", > > > > > > + "arm,mali-t720"; > > > > > > + reg =3D <0x01800000 0x4000>; > > > > > > + interrupts =3D > > > > > > > > > IRQ_TYPE_LEVEL_HIGH>, > > > > > > > > > > > + > > > > > > > > > IRQ_TYPE_LEVEL_HIGH>, > > > > > > > > > > > + > > > > > > > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > > > > > > > + interrupt-names =3D "job", "mmu", "gpu"; > > > > > > + clocks =3D <&ccu CLK_GPU>, <&ccu CLK_BUS_= GPU>; > > > > > > + clock-names =3D "core", "bus"; > > > > > > + resets =3D <&ccu RST_BUS_GPU>; > > > > > > + status =3D "disabled"; > > > > > > > > > > Usually self sufficient peripherals are enabled by default in DTS= I. > > > > > > > > I follow the other Mali Midgard (rk3399, rk3288) syntax. > > > > But I think you're right here, will go for an update I think. > > > > > > I quickly checked A64 and H5 DTSI and both have GPU enabled by default > > > (status property is not set). > > > > I asked myself the same question, but the H6 seems to have a supply > > wired to the GPU, while the H3 and H5 do not. So I'm not sure we want > > to enable it on all the boards, even though some might have left out > > the GPU supply which will result in a non-working GPU (I assume?) > > It's true that GPU doesn't work at all without power supply. Even worse, = ARM > kernel driver just hangs whole SoC if it tries to use unpowered GPU. > > I checked few datasheets and almost none of them have GPU power supply, e= xcept > H5, where GPU is enabled by default in DTSI. I guess we should fix that then. > Yeah, I guess it's more safe to explicitly enable it in board DT. It's also something we do for the CPU, even though the CPU should be obviously be powered before starting Linux... Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ughvejlzbua5n4db Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXK9iQQAKCRDj7w1vZxhR xW8KAQC6G/zptIZMa3Iez/W7WOhXWk54gWQ0gUOe1wOvm5zMFgEAkYt6r8m5dYvW QFoyycKpJudgsTM0htXFB3AyjlPEag8= =fNBG -----END PGP SIGNATURE----- --ughvejlzbua5n4db--