From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BF04C282CE for ; Fri, 12 Apr 2019 11:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66DBE2171F for ; Fri, 12 Apr 2019 11:45:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727070AbfDLLpG convert rfc822-to-8bit (ORCPT ); Fri, 12 Apr 2019 07:45:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:40246 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726714AbfDLLpF (ORCPT ); Fri, 12 Apr 2019 07:45:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 780D8AC89; Fri, 12 Apr 2019 11:45:04 +0000 (UTC) Date: Fri, 12 Apr 2019 13:44:59 +0200 From: Thomas Bogendoerfer To: Alexandre Belloni Cc: Joshua Kinard , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] rtc: ds1685: use correct device struct to get platform device struct Message-Id: <20190412134459.446ef705c86aa1c7b926abc7@suse.de> In-Reply-To: <20190412101106.GU3578@piout.net> References: <20190411143323.20945-1-tbogendoerfer@suse.de> <20190411143323.20945-2-tbogendoerfer@suse.de> <20190412101106.GU3578@piout.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Apr 2019 12:11:06 +0200 Alexandre Belloni wrote: > Every patch need a commit message. Maybe you could indicate that this > never gave any issue because parent is the first member of struct > device. I'll update the commit message, I get a nice stacktrace because of that bug, so the path from work_queue calling ds1685_rtc_poweroff never worked. Thomas. -- SUSE Linux GmbH GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)