From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3800C10F0E for ; Fri, 12 Apr 2019 13:52:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C05282084D for ; Fri, 12 Apr 2019 13:52:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="bYG6mzgT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbfDLNwR (ORCPT ); Fri, 12 Apr 2019 09:52:17 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:39180 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbfDLNwR (ORCPT ); Fri, 12 Apr 2019 09:52:17 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3CDmSAX175532; Fri, 12 Apr 2019 13:51:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=ovEpyDuGb4JExSqzKiIaVjsKdw2bkli5bpnC/AZvFK0=; b=bYG6mzgTU/g2FWN85Nk0lz1otsG8Yyd61dLFlev9/l+kqyusKFf83wuMDN4ly9upv+EA RSfIfk+7k2A3GjXyWey9Zx4ScwjfMuhD/4zoGziIYQiy4Nl7tsLYmPgm9omCxn1o5UN+ Ybv+cx2Xzn6huZJ56zNSx9UTmo9+NU+sLkLizsZtMDabCbhn+VRlZ6yopPMBeU+3OUWm ihcdk07tUUeWBkuBo9vWOTXDzMDWjZDSqDiMJtOgXwDufCI/fO9Qb6q6ikq2ELGbygNU J/eA/CqMYSONlvPrCR29YS18zJ2pIkOF8e1ZS5JUFVQJo5PPSwAUAeUvgWKDJ3M4ipGH xg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2rphmexrgh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Apr 2019 13:51:59 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3CDpndL138323; Fri, 12 Apr 2019 13:51:58 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2rpytdardx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Apr 2019 13:51:58 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x3CDprUT028316; Fri, 12 Apr 2019 13:51:53 GMT Received: from kadam (/197.157.0.25) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 12 Apr 2019 06:51:51 -0700 Date: Fri, 12 Apr 2019 16:51:45 +0300 From: Dan Carpenter To: Gao Xiang Cc: Chao Yu , Ming Lei , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org, Chao Yu , LKML , weidu.du@huawei.com, Fang Wei , Miao Xie Subject: Re: [PATCH v2] staging: erofs: fix unexpected out-of-bound data access Message-ID: <20190412135145.GK6095@kadam> References: <20190412095314.224932-1-gaoxiang25@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190412095314.224932-1-gaoxiang25@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9224 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=918 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904120091 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9224 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=939 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904120091 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 12, 2019 at 05:53:14PM +0800, Gao Xiang wrote: > Unexpected out-of-bound data will be read in erofs_read_raw_page > after commit 07173c3ec276 ("block: enable multipage bvecs") since > one iovec could have multiple pages. > > Let's fix as what Ming's pointed out in the previous email [1]. > > [1] https://lore.kernel.org/lkml/20190411080953.GE421@ming.t460p/ > Please also use the Fixes tag. Fixes: 07173c3ec276 ("block: enable multipage bvecs") > Suggested-by: Ming Lei > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang regards, dan carpenter