From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD03C10F14 for ; Fri, 12 Apr 2019 21:30:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7D8820850 for ; Fri, 12 Apr 2019 21:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbfDLVaq (ORCPT ); Fri, 12 Apr 2019 17:30:46 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:35077 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726771AbfDLVap (ORCPT ); Fri, 12 Apr 2019 17:30:45 -0400 Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id EE9A3200009; Fri, 12 Apr 2019 21:30:42 +0000 (UTC) Date: Fri, 12 Apr 2019 23:30:42 +0200 From: Alexandre Belloni To: Han Nandor Cc: "a.zummo@towertech.it" , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/1] rtc: ds3232: get SRAM access using NVMEM Framework Message-ID: <20190412213042.GB3578@piout.net> References: <20190408085141.21284-1-nandor.han@vaisala.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408085141.21284-1-nandor.han@vaisala.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/04/2019 08:52:39+0000, Han Nandor wrote: > static int ds3232_probe(struct device *dev, struct regmap *regmap, int irq, > const char *name) > { > struct ds3232 *ds3232; > int ret; > + struct nvmem_config nvmem_cfg; > > ds3232 = devm_kzalloc(dev, sizeof(*ds3232), GFP_KERNEL); > if (!ds3232) > @@ -476,6 +499,15 @@ static int ds3232_probe(struct device *dev, struct regmap *regmap, int irq, > ds3232->dev = dev; > dev_set_drvdata(dev, ds3232); > > + nvmem_cfg.name = "ds3232_sram"; > + nvmem_cfg.stride = 1; > + nvmem_cfg.size = DS3232_REG_SRAM_SIZE; > + nvmem_cfg.word_size = 1; > + nvmem_cfg.reg_read = ds3232_nvmem_read; > + nvmem_cfg.reg_write = ds3232_nvmem_write; > + nvmem_cfg.priv = ds3232; > + nvmem_cfg.type = NVMEM_TYPE_BATTERY_BACKED; > + You have to either initialize at the declaration as done here: https://elixir.bootlin.com/linux/v5.0/source/drivers/rtc/rtc-rv8803.c#L530 or memset the struct to 0. Else, this leaves members uninitialized. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com