From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E564C10F11 for ; Sat, 13 Apr 2019 07:54:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E788B20869 for ; Sat, 13 Apr 2019 07:53:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="P1HPZ99D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727212AbfDMHx6 (ORCPT ); Sat, 13 Apr 2019 03:53:58 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40074 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbfDMHx6 (ORCPT ); Sat, 13 Apr 2019 03:53:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OKL2bgXFvu/qx9sw+X/h2Tm3lT/Fyuo+IjvFHTXkV04=; b=P1HPZ99DqYyqOD9J4xGMpOOXf TtX2PZpSo224m4Xu2WTPXlmWuXg28vbKs8L4V5AFwph2UNGuo6M/eaDchvjKjT6zvwPOjL+jsjyBX jSby68JEtkrxRrs1I/FsymBq0Hgf7szsHzV2yf+whpssoIFoV2P/4g+Ks14ROXnZ5k3U8A+xNssRW wGL1k7juwuN+4eDcVTtxOi2pFB3c0NcqsY65QtW/sSTGclcRMRAxfTcArOGeF8sITGilugJWXv5li VOHo6jWFnesftmUkxA+AysQBMGrfP+M0P6gomO4XCjvkRfgpqiiiUD/FZUuggxC5efeIIX5+Pdj3W kWcchCBYA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFDU4-00083G-1x; Sat, 13 Apr 2019 07:53:56 +0000 Date: Sat, 13 Apr 2019 00:53:55 -0700 From: Christoph Hellwig To: Anup Patel Cc: Palmer Dabbelt , Albert Ou , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Atish Patra , Paul Walmsley , "linux-riscv@lists.infradead.org" Subject: Re: [PATCH 1/3] RISC-V: Add separate asm/encoding.h for spec related defines Message-ID: <20190413075355.GA30428@infradead.org> References: <20190413073906.53676-1-anup.patel@wdc.com> <20190413073906.53676-2-anup.patel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190413073906.53676-2-anup.patel@wdc.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 13, 2019 at 07:39:35AM +0000, Anup Patel wrote: > It's better to have all RISC-V spec related defines in one place > so this patch adds separate asm/encoding.h for such defines which > can be included in assembly as well as C code. can be included from assembly just fine already. and we already do that. So I don't really see much of a point in splitting it.