From: Borislav Petkov <bp@alien8.de>
To: Atish Patra <atish.patra@wdc.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Anup Patel <anup@brainfault.org>,
Palmer Dabbelt <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Gary Guo <gary@garyguo.net>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: Re: [1/3] x86: Update DEBUG_TLBFLUSH options description.
Date: Sun, 14 Apr 2019 16:27:09 +0200 [thread overview]
Message-ID: <20190414142709.GA569@zn.tnic> (raw)
In-Reply-To: <580d95d1-224f-a372-c656-1d2cbb19d868@wdc.com>
On Fri, Apr 12, 2019 at 01:14:54PM -0700, Atish Patra wrote:
> On 4/10/19 11:56 PM, Christoph Hellwig wrote:
> > Given that this option enables generic code (which you reuse for RISC-V
> > later in this series) please also move the config option to
> > mm/Kconfig, proabbly keyed off another ARCH_HAVE_DEBUG_TLBFLUSH
> > symbol that the architecture can select.
> >
>
> Sure.
And when you do that, instead of deleting the help text, make it
generic. Otherwise, there's no explanation anymore, how that option is
supposed to be used through tlb_flushall_shift.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-14 14:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 22:44 [0/3] TLB flush counters Atish Patra
2019-04-10 22:44 ` [1/3] x86: Update DEBUG_TLBFLUSH options description Atish Patra
2019-04-11 6:56 ` Christoph Hellwig
2019-04-12 20:14 ` Atish Patra
2019-04-14 14:27 ` Borislav Petkov [this message]
2019-04-29 19:52 ` Atish Patra
2019-04-25 20:17 ` Palmer Dabbelt
2019-04-10 22:44 ` [2/3] RISC-V: Update tlb flush counters Atish Patra
2019-04-25 20:17 ` Palmer Dabbelt
2019-04-26 18:54 ` Atish Patra
2019-04-10 22:44 ` [3/3] RISC-V: Add DEBUG_TLBFLUSH option Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190414142709.GA569@zn.tnic \
--to=bp@alien8.de \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=gary@garyguo.net \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mingo@redhat.com \
--cc=palmer@sifive.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®