From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 548ABC10F13 for ; Sun, 14 Apr 2019 18:35:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB8082075B for ; Sun, 14 Apr 2019 18:35:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pYecM7C4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727240AbfDNSfQ (ORCPT ); Sun, 14 Apr 2019 14:35:16 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:42464 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726262AbfDNSfN (ORCPT ); Sun, 14 Apr 2019 14:35:13 -0400 Received: by mail-pl1-f196.google.com with SMTP id cv12so7468962plb.9; Sun, 14 Apr 2019 11:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vb9uAQH/o2De1YmvUYnPDAc0vIUTfBsphA2YuXBH1ZI=; b=pYecM7C4gGigGcvlpot9Mk+4pwxpbC14HZLV7HyubPO4ihNKGgIFC5+ZT7z3f6rZb3 dsshWFhpbjn8NKBI9MWx7+vGmPX/Q8RSJABXOFK3+mZ9EIgU11Kp71j09qtjU7+jN0SQ 94FY+DD7rOmC7dqzKX+wHinCBM0s2kX3lRZR9n4GqTvhRR8s3xsc+8x0mV2JKH/yX/lD 0ta5Ioxyhn37ijNhYcc+oyTxjyAHouNMPCio9Ot4R+VNcd8OJHLRs/xihFQTluApqCeg g8agGz7WArhntfi7d2DVCYIa1I3BTcfUD0TkhC1fNNZ1JkfbTubzZd4qrYYp3FVzpt89 xT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Vb9uAQH/o2De1YmvUYnPDAc0vIUTfBsphA2YuXBH1ZI=; b=seP0wUO+4tfCPkdrfFtClNXfGhILlqXoh9IpWZZgVSMr5JrJP7cvIn/pV8ClERP00S CtPHiMS7QX1HiFG35zpAW5sbtqYPH7VzRdYy+KUjWOInbDbhQryMlqq0bqquoYvQl294 WM9YUwOukJ8pgOB+d6gHZj94kcJiO3H7QoY3n293cZrjFjkFSzubm36fHTpGXG9A/k5I u+Ud6oL9cZiJaDqApmcGXyx1FTEzUB8ij64EliOMPP4LDO2r78vfUUfUDRJcqK885P+6 3HqLUIG0w8S7EksSrD8pz7UUnarrfhbm9R3Xz2K85eCQ2dTAkdm57PYHek1ydEf/m9IQ vCqA== X-Gm-Message-State: APjAAAVwftbZ3+A0oluS5EinRU4p0gKTPdbi01lj3n/HqQmch0bum7Lu sncIFkNPt8CGkkEAM6i4vaIhQJv0 X-Google-Smtp-Source: APXvYqy5E6XUsGX0s99j8AsbtDc3NMelajCgrF+5lDF/4o0KatMAykAI327EKf1lUlgXqIG2+QRp3g== X-Received: by 2002:a17:902:8d97:: with SMTP id v23mr36437978plo.298.1555266911922; Sun, 14 Apr 2019 11:35:11 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id p7sm83791758pfp.70.2019.04.14.11.35.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Apr 2019 11:35:11 -0700 (PDT) From: Andrey Smirnov To: linux-iio@vger.kernel.org Cc: Andrey Smirnov , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Chris Healy , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/6] iio: imx7d_adc: Add local struct device pointer in imx7d_adc_probe() Date: Sun, 14 Apr 2019 11:34:59 -0700 Message-Id: <20190414183504.23286-2-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190414183504.23286-1-andrew.smirnov@gmail.com> References: <20190414183504.23286-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use a local "struct device *dev" in imx7d_adc_probe() for brevity. No functional change intended. Signed-off-by: Andrey Smirnov Cc: Jonathan Cameron Cc: Hartmut Knaack Cc: Lars-Peter Clausen Cc: Peter Meerwald-Stadler Cc: Chris Healy Cc: linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/iio/adc/imx7d_adc.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c index ad6764fb2a23..3bbd657409d5 100644 --- a/drivers/iio/adc/imx7d_adc.c +++ b/drivers/iio/adc/imx7d_adc.c @@ -438,51 +438,51 @@ static int imx7d_adc_probe(struct platform_device *pdev) struct imx7d_adc *info; struct iio_dev *indio_dev; struct resource *mem; + struct device *dev = &pdev->dev; int irq; int ret; - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*info)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*info)); if (!indio_dev) { dev_err(&pdev->dev, "Failed allocating iio device\n"); return -ENOMEM; } info = iio_priv(indio_dev); - info->dev = &pdev->dev; + info->dev = dev; mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - info->regs = devm_ioremap_resource(&pdev->dev, mem); + info->regs = devm_ioremap_resource(dev, mem); if (IS_ERR(info->regs)) { ret = PTR_ERR(info->regs); - dev_err(&pdev->dev, - "Failed to remap adc memory, err = %d\n", ret); + dev_err(dev, "Failed to remap adc memory, err = %d\n", ret); return ret; } irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "No irq resource?\n"); + dev_err(dev, "No irq resource?\n"); return irq; } - info->clk = devm_clk_get(&pdev->dev, "adc"); + info->clk = devm_clk_get(dev, "adc"); if (IS_ERR(info->clk)) { ret = PTR_ERR(info->clk); - dev_err(&pdev->dev, "Failed getting clock, err = %d\n", ret); + dev_err(dev, "Failed getting clock, err = %d\n", ret); return ret; } - info->vref = devm_regulator_get(&pdev->dev, "vref"); + info->vref = devm_regulator_get(dev, "vref"); if (IS_ERR(info->vref)) { ret = PTR_ERR(info->vref); - dev_err(&pdev->dev, + dev_err(dev, "Failed getting reference voltage, err = %d\n", ret); return ret; } ret = regulator_enable(info->vref); if (ret) { - dev_err(&pdev->dev, + dev_err(dev, "Can't enable adc reference top voltage, err = %d\n", ret); return ret; @@ -492,8 +492,8 @@ static int imx7d_adc_probe(struct platform_device *pdev) init_completion(&info->completion); - indio_dev->name = dev_name(&pdev->dev); - indio_dev->dev.parent = &pdev->dev; + indio_dev->name = dev_name(dev); + indio_dev->dev.parent = dev; indio_dev->info = &imx7d_adc_iio_info; indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->channels = imx7d_adc_iio_channels; @@ -501,16 +501,15 @@ static int imx7d_adc_probe(struct platform_device *pdev) ret = clk_prepare_enable(info->clk); if (ret) { - dev_err(&pdev->dev, - "Could not prepare or enable the clock.\n"); + dev_err(dev, "Could not prepare or enable the clock.\n"); goto error_adc_clk_enable; } - ret = devm_request_irq(info->dev, irq, - imx7d_adc_isr, 0, - dev_name(&pdev->dev), info); + ret = devm_request_irq(dev, irq, + imx7d_adc_isr, 0, + dev_name(dev), info); if (ret < 0) { - dev_err(&pdev->dev, "Failed requesting irq, irq = %d\n", irq); + dev_err(dev, "Failed requesting irq, irq = %d\n", irq); goto error_iio_device_register; } -- 2.20.1