From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0DAAC10F0E for ; Mon, 15 Apr 2019 14:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 874452087C for ; Mon, 15 Apr 2019 14:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727470AbfDOOmz (ORCPT ); Mon, 15 Apr 2019 10:42:55 -0400 Received: from foss.arm.com ([217.140.101.70]:36188 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726259AbfDOOmy (ORCPT ); Mon, 15 Apr 2019 10:42:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53845374; Mon, 15 Apr 2019 07:42:54 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 666773F68F; Mon, 15 Apr 2019 07:42:53 -0700 (PDT) Date: Mon, 15 Apr 2019 15:42:46 +0100 From: Mark Rutland To: Dmitry Vyukov , Andrew Morton Cc: LKML , Kees Cook Subject: Re: [PATCH] kcov: improve CONFIG_ARCH_HAS_KCOV help text Message-ID: <20190415144246.GA24230@lakrids.cambridge.arm.com> References: <20190412102733.5154-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 12, 2019 at 12:31:10PM +0200, Dmitry Vyukov wrote: > On Fri, Apr 12, 2019 at 12:27 PM Mark Rutland wrote: > > > > The help text for CONFIG_ARCH_HAS_KCOV is stale, and describes the > > feature as being enabled only for x86_64, when it is now enabled for > > several architectures, including arm, arm64, powerpc, and s390. > > > > Let's remove that stale help text, and update it along the lines of hat > > for ARCH_HAS_FORTIFY_SOURCE, better describing when an architecture > > should select CONFIG_ARCH_HAS_KCOV. > > > > Signed-off-by: Mark Rutland > > Cc: Andrew Morton > > Cc: Dmitry Vyukov > > Cc: Kees Cook > > --- > > lib/Kconfig.debug | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 0d9e81779e37..00dbcdbc9a0d 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -753,9 +753,9 @@ endmenu # "Memory Debugging" > > config ARCH_HAS_KCOV > > bool > > help > > - KCOV does not have any arch-specific code, but currently it is enabled > > - only for x86_64. KCOV requires testing on other archs, and most likely > > - disabling of instrumentation for some early boot code. > > + An architecture should select this when it can successfully > > + build and run with CONFIG_KCOV. This typically requires > > + disabling instrumentation for some early boot code. > > > > config CC_HAS_SANCOV_TRACE_PC > > def_bool $(cc-option,-fsanitize-coverage=trace-pc) > > -- > > 2.11.0 > > > Acked-by: Dmitry Vyukov Thanks! Andrew, are you happy to pick this up? Mark.