mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Kees Cook <keescook@chromium.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Alex Matveev <alxmtvv@gmail.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Yury Norov <ynorov@caviumnetworks.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] arm64: sysreg: make mrs_s and msr_s macros work with Clang and LTO
Date: Tue, 16 Apr 2019 18:08:09 +0100	[thread overview]
Message-ID: <20190416170808.GC54708@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <CAKwvOdk_jFQKW2C2=925So_dvZ6dm03AXMZ9Nk+O1J2xyhE2EA@mail.gmail.com>

On Mon, Apr 15, 2019 at 10:22:27AM -0700, Nick Desaulniers wrote:
> On Mon, Apr 15, 2019 at 10:06 AM Mark Rutland <mark.rutland@arm.com> wrote:
> > It would be nice if we could simply rely on a more recent binutils these
> > days, which supports the generic S<op0>_<op1>_<cn>_<Cm>_<op2> sysreg
> > definition. That would mean we could get rid of the whole msr_s/mrs_s
> > hack by turning that into a CPP macro which built that name.
> >
> > It looks like binutils has been able to do that since September 2014...
> >
> > Are folk using toolchains older than that to compile kernels?
> 
> Do you have a link to a commit?  If we can pinpoint the binutils
> version, that might help.

IIUC any version of binutils with commit:

  df7b4545b2b49572 ("[PATCH/AArch64] Generic support for all system registers using mrs and msr")

... should be sufficent.

That's on gitweb at:

  https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=df7b4545b2b49572ab63690c130df973af109615

> Also, I look forward to this patch for use of Clang's integrated
> assembler (regardless of LTO).  I remember getting frustrated trying
> to figure out how to resolve this for both assemblers, and I had
> forgotten this solution existed.

Is this the only blocker for the integrated assembler?

Thanks,
Mark.

  reply	other threads:[~2019-04-16 17:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 14:38 Kees Cook
2019-04-15 17:06 ` Mark Rutland
2019-04-15 17:22   ` Nick Desaulniers
2019-04-16 17:08     ` Mark Rutland [this message]
2019-04-16 17:34       ` Nick Desaulniers
2019-04-17  4:02       ` Kees Cook
2019-04-22 17:44         ` Nick Desaulniers
2019-04-23 14:12           ` Mark Rutland
2019-04-23 18:15             ` Nick Desaulniers
2019-04-23 18:24               ` Kees Cook
2019-04-23 18:39                 ` Arnd Bergmann
2019-04-16 17:18     ` Mark Rutland
2019-04-23 22:55 ` Kees Cook
2019-04-23 22:57   ` Ard Biesheuvel
2019-04-23 22:59     ` Nick Desaulniers
2019-04-23 23:09       ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416170808.GC54708@lakrids.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=alxmtvv@gmail.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=ndesaulniers@google.com \
    --cc=samitolvanen@google.com \
    --cc=will.deacon@arm.com \
    --cc=ynorov@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®