From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8768AC10F13 for ; Tue, 16 Apr 2019 17:38:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5574D2073F for ; Tue, 16 Apr 2019 17:38:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="EWO6j0qA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730194AbfDPRi5 (ORCPT ); Tue, 16 Apr 2019 13:38:57 -0400 Received: from merlin.infradead.org ([205.233.59.134]:48506 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728000AbfDPRi4 (ORCPT ); Tue, 16 Apr 2019 13:38:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6EEJiDW9Bw+tZ9Z45VRoDn4HrtgmE0ZYCu1+dNzEukI=; b=EWO6j0qABhnyKEzP42E3PW8Ud lWA7GgsqBc9ZZExXVrbVxUGQNxWwm/0Oq298Rk6qBkJGJksZ4mT1xvNrP3SfDCK/6bCoL65AJzj9V MBPkMxJn+zOg2CGBpzdi1BqUkwGnSiJa8M3o9ZunppX8FsTdFNjsAiwhTOBqOxhF45ruxh5e1Zch9 JtYPmOdQ1wSKpebQZwXAz5kMkgsyHHgeJX2qTJzlFlgDT0D5lQYls2rfvfGDu0Wh+deFXzTLPs6l7 3ddjYc5ZyDfdAlexYAgmbakagtMKeQHaZGQyWGjENZ25V4zQSemJ+rgec5g9STf0y7j7COLpTeghV ugnnuk6xw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGS2h-0004iT-BD; Tue, 16 Apr 2019 17:38:47 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 190FE25E4A93A; Tue, 16 Apr 2019 19:38:46 +0200 (CEST) Date: Tue, 16 Apr 2019 19:38:46 +0200 From: Peter Zijlstra To: Jakub Kicinski Cc: tglx@linutronix.de, David Miller , ard.biesheuvel@linaro.org, yamada.masahiro@socionext.com, mingo@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, alexei.starovoitov@gmail.com Subject: Re: [PATCH 0/3] locking/static_key: improve rate limited labels Message-ID: <20190416173846.GR4038@hirez.programming.kicks-ass.net> References: <20190330000854.30142-1-jakub.kicinski@netronome.com> <20190401112153.2f9e87ba@cakuba.hsd1.ca.comcast.net> <20190404102902.GW4038@hirez.programming.kicks-ass.net> <20190416093315.4f8fee4f@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416093315.4f8fee4f@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 16, 2019 at 09:33:15AM -0700, Jakub Kicinski wrote: > On Thu, 4 Apr 2019 12:29:02 +0200, Peter Zijlstra wrote: > > On Mon, Apr 01, 2019 at 11:21:53AM -0700, Jakub Kicinski wrote: > > > On Fri, 29 Mar 2019 17:08:51 -0700, Jakub Kicinski wrote: > > > > Hi! > > > > > > > > This will be used to fix the static branch disabling in the TLS > > > > code. The net/tls/ code should be using the deferred static > > > > branch type, because unprivileged users can flip the branch > > > > on and off quite easily with CONFIG_TLS_DEVICE=y. > > > > > > > > Second of all we shouldn't take the jump label locks from > > > > the RX path, when the socket is destroyed. This can be avoided > > > > with some slight code refactoring in deferred static_key as > > > > it already runs from a workqueue. > > > > > > > > This the series (and a simple tls patch which makes use of it) > > > > applied opening 0.5M TLS connections to localhost (just calling > > > > setsockopt, no data exchange) goes down from 37.9s to 12.4s. > > > > > > Once/if we get positive feedback from locking folks, would it be > > > possible to merge these via net-next tree alongside the patch > > > converting TLS to rate limited branches? > > > > Looks good. If routed through the network tree because usage there: > > > > Acked-by: Peter Zijlstra (Intel) > > > > Otherwise let me know and I'll carry them. > > Hi Peter! I was initially hoping that a1247d06d010 > ("locking/static_key: Fix false positive warnings on concurrent dec/inc") > may go into 5.1, but it's not really a regression. It will conflict, so > the net-next route won't work. Would you be able to carry this set > after all? n/p, done!