From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: Guenter Roeck <linux@roeck-us.net>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] sparc/iommu: use !PageHighMem to check if a page has a kernel mapping
Date: Tue, 16 Apr 2019 20:23:39 +0200 [thread overview]
Message-ID: <20190416182347.18441-2-hch@lst.de> (raw)
In-Reply-To: <20190416182347.18441-1-hch@lst.de>
This deobsfucates the check a bit, and prepares for future changes.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Guenter Roeck <linux@roeck-us.net>
---
arch/sparc/mm/iommu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/sparc/mm/iommu.c b/arch/sparc/mm/iommu.c
index e8d5d73ca40d..dcdadac03fdf 100644
--- a/arch/sparc/mm/iommu.c
+++ b/arch/sparc/mm/iommu.c
@@ -273,7 +273,8 @@ static int sbus_iommu_map_sg_pflush(struct device *dev, struct scatterlist *sgl,
* XXX Is this a good assumption?
* XXX What if someone else unmaps it here and races us?
*/
- if ((page = (unsigned long) page_address(sg_page(sg))) != 0) {
+ if (!PageHighMem(sg_page(sg))) {
+ page = (unsigned long)page_address(sg_page(sg));
for (i = 0; i < n; i++) {
if (page != oldpage) { /* Already flushed? */
flush_page_for_dma(page);
--
2.20.1
next prev parent reply other threads:[~2019-04-16 18:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 18:23 fix SG list handling in the sparc32 iommu driver Christoph Hellwig
2019-04-16 18:23 ` Christoph Hellwig [this message]
2019-04-16 18:23 ` [PATCH 2/9] sparc/iommu: use sbus_iommu_unmap_page in sbus_iommu_unmap_sg Christoph Hellwig
2019-04-16 18:23 ` [PATCH 3/9] sparc/iommu: merge iommu_release_one and sbus_iommu_unmap_page Christoph Hellwig
2019-04-16 18:23 ` [PATCH 4/9] sparc/iommu: create a common helper for map_sg Christoph Hellwig
2019-04-16 18:23 ` [PATCH 5/9] sparc/iommu: pass a physical address to iommu_get_one Christoph Hellwig
2019-04-16 18:23 ` [PATCH 6/9] sparc/iommu: move per-page flushing into __sbus_iommu_map_page Christoph Hellwig
2019-04-16 18:23 ` [PATCH 7/9] sparc/iommu: fix __sbus_iommu_map_page for highmem pages Christoph Hellwig
2019-04-16 18:23 ` [PATCH 8/9] sparc/iommu: use __sbus_iommu_map_page to implement the map_sg path Christoph Hellwig
2019-04-16 18:23 ` [PATCH 9/9] sparc/iommu: merge iommu_get_one and __sbus_iommu_map_page Christoph Hellwig
2019-04-16 19:35 ` fix SG list handling in the sparc32 iommu driver Guenter Roeck
2019-04-30 13:17 ` Christoph Hellwig
2019-05-09 0:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416182347.18441-2-hch@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome