From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22217C10F14 for ; Wed, 17 Apr 2019 01:38:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC6A520821 for ; Wed, 17 Apr 2019 01:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729734AbfDQBir (ORCPT ); Tue, 16 Apr 2019 21:38:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56798 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728514AbfDQBir (ORCPT ); Tue, 16 Apr 2019 21:38:47 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27C6246202; Wed, 17 Apr 2019 01:38:47 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-87.pek2.redhat.com [10.72.12.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADED65D707; Wed, 17 Apr 2019 01:38:42 +0000 (UTC) Date: Wed, 17 Apr 2019 09:38:38 +0800 From: Dave Young To: Borislav Petkov Cc: Junichi Nomura , Chao Fan , Baoquan He , Kairui Song , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels Message-ID: <20190417013838.GA8411@dhcp-128-65.nay.redhat.com> References: <20190412084956.GC19808@zn.tnic> <20190412133528.GD19808@zn.tnic> <20190415090717.GA29317@zn.tnic> <20190415102525.GB29317@zn.tnic> <23309b73-d135-a207-564b-6003cee39184@ce.jp.nec.com> <20190416094024.GE27892@zn.tnic> <20190416095209.GG27892@zn.tnic> <20190416114133.GA7541@dhcp-128-65.nay.redhat.com> <20190416132253.GE31772@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416132253.GE31772@zn.tnic> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 17 Apr 2019 01:38:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16/19 at 03:22pm, Borislav Petkov wrote: > On Tue, Apr 16, 2019 at 07:41:33PM +0800, Dave Young wrote: > > On 04/16/19 at 11:52am, Borislav Petkov wrote: > > > I'll queue the below in the next days if there are no more complaints: > > > > As for the kexec breakage, even with the V3 patch, kexec still hangs on > > a Lenovo T420 laptop. Kairui also reproduced the problem. So can we > > wait a few days see if we can make some progress to find the cause? > > How is applying this patch going to change anything? > > I was told that the breakage is there even without it... Without this patch, the bug happens in the efi_get_rsdp.. function, this patch tries to fix that by adding kexec_get.. but the new introduced kexec_* function does not work on some laptops, so it is not a 100% good fix, I hoped we can get it working for all known issues. But if we can not do it eg. within one week we can go with this version and leave the laptop issue as a known issue. But if you want to apply it now, I think it is fine as well, probably the laptop issue is lenovo firmware specific, we can add rsdp in cmdline or boot params via kexec-tools so it should be good by using new kexec-tools. Thanks Dave