From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF41C10F12 for ; Wed, 17 Apr 2019 06:34:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 115FE20693 for ; Wed, 17 Apr 2019 06:34:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729854AbfDQGeN (ORCPT ); Wed, 17 Apr 2019 02:34:13 -0400 Received: from verein.lst.de ([213.95.11.211]:40537 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbfDQGeM (ORCPT ); Wed, 17 Apr 2019 02:34:12 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id B66FE68AFE; Wed, 17 Apr 2019 08:33:58 +0200 (CEST) Date: Wed, 17 Apr 2019 08:33:58 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers Message-ID: <20190417063358.GA24139@lst.de> References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410061157.GA5278@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 08:11:57AM +0200, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 06:59:32PM +0100, Robin Murphy wrote: > > On 27/03/2019 08:04, Christoph Hellwig wrote: > >> This keeps the code together and will simplify compiling the code > >> out on architectures that are always dma coherent. > > > > And this is where things take a turn in the direction I just can't get on > > with - I'm looking at the final result and the twisty maze of little > > disjoint helpers all overlapping each other in functionality is really > > difficult to follow. And I would *much* rather have things rely on > > compile-time constant optimisation than spend the future having to fix the > > #ifdefed parts for arm64 whenever x86-centric changes fail to test them. > > Can you draft up a patch on top of my series to show me what you > want? I can take care of finishing it up and moving the changes > into the right patches in the series. Any chance to make some progress on this? Or at least a better description of what you want?