From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5540C282DD for ; Wed, 17 Apr 2019 11:46:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C13E21773 for ; Wed, 17 Apr 2019 11:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555501585; bh=RwkFnXr/uoD3P62yfD/tFAkp7I2IJV+HMntTkDiwEqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=b/5YWqJXw+5isoAtB+mKlgBLTCf0JRQOnqlPV6Tc1QxHT8efFWjB4/P/H9f5Z5sDx tJukRNbjroT16/WF2TE2fmmpksCzzmRFag6/f/WJIh7CQ5XevI41XZLNhtPrOJfjs1 vZagkn5h05UD80RJ0A7TxitVK2DHdDEDvhEHs0Yo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731929AbfDQLqY (ORCPT ); Wed, 17 Apr 2019 07:46:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:42630 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729522AbfDQLqY (ORCPT ); Wed, 17 Apr 2019 07:46:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A8FE3AFBD; Wed, 17 Apr 2019 11:46:22 +0000 (UTC) Date: Wed, 17 Apr 2019 13:46:21 +0200 From: Michal Hocko To: Zhaoyang Huang Cc: Andrew Morton , Vlastimil Babka , Joonsoo Kim , David Rientjes , Zhaoyang Huang , Roman Gushchin , Jeff Layton , "open list:MEMORY MANAGEMENT" , LKML , Pavel Tatashin , Johannes Weiner , Matthew Wilcox Subject: Re: [RFC PATCH] mm/workingset : judge file page activity via timestamp Message-ID: <20190417114621.GF5878@dhcp22.suse.cz> References: <1555487246-15764-1-git-send-email-huangzhaoyang@gmail.com> <20190417110615.GC5878@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 17-04-19 19:36:21, Zhaoyang Huang wrote: > sorry for the confusion. What I mean is the basic idea doesn't change > as replacing the refault criteria from refault_distance to timestamp. > But the detailed implementation changed a lot, including fix bugs, > update the way of packing the timestamp, 32bit/64bit differentiation > etc. So it makes sense for starting a new context. Not really. My take away from the previous discussion is that Johannes has questioned the timestamping approach itself. I wasn't following very closely so I might be wrong here but if that is really the case then it doesn't make much sense to improve the implementation if there is no consensus on the approach itself. -- Michal Hocko SUSE Labs