From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B71C10F0B for ; Thu, 18 Apr 2019 07:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A35B02183F for ; Thu, 18 Apr 2019 07:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388228AbfDRHp4 (ORCPT ); Thu, 18 Apr 2019 03:45:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:60286 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726873AbfDRHpz (ORCPT ); Thu, 18 Apr 2019 03:45:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 82858AD49; Thu, 18 Apr 2019 07:45:54 +0000 (UTC) Date: Thu, 18 Apr 2019 09:45:52 +0200 From: Petr Mladek To: Sergey Senozhatsky Cc: Feng Tang , Andrew Morton , Steven Rostedt , linux-kernel@vger.kernel.org, Kees Cook , Borislav Petkov , ying.huang@intel.com Subject: Re: [PATCH v2] panic: add an option to replay all the printk message in buffer Message-ID: <20190418074552.x7bl7tr76dui64f5@pathway.suse.cz> References: <20190410153718.22905-1-feng.tang@intel.com> <20190416211922.d3c9c6987f0b992da343be52@linux-foundation.org> <20190417064844.ppyqxcx2mgek5455@shbuild888> <20190417091832.z252cvcf4ktxeamv@pathway.suse.cz> <20190417094614.GB4260@jagdpanzerIV> <20190417105010.GA8492@jagdpanzerIV> <20190417122458.mhl3orevzha7sp6h@pathway.suse.cz> <20190417151817.xsun2k7cxff5rknn@shbuild888> <20190418000014.GA2059@jagdpanzerIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190418000014.GA2059@jagdpanzerIV> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2019-04-18 09:00:14, Sergey Senozhatsky wrote: > I think that PANIC_PRINT_ALL_PRINTK_MSG is a debugging option; a quite > specific one. So people who ask the kernel to PANIC_PRINT_ALL_PRINTK_MSG > they know what they are doing, and we probably will not cofuse anyone. > After all, we don't print any headers when we ftrace_dump() or imitate > sysrq via sysrq_timer_list_show(), or for any other panic_print_sys_info() > printouts. So it's OK to just do the simple thing for > PANIC_PRINT_ALL_PRINTK_MSG. The following functions are currently called from panic_print_sys_info(): + show_state(): printk(KERN_INFO " task PC stack pid father\n"); + show_mem(): printk("Mem-Info:\n"); + sysrq_timer_list_show() no global header; but each section can be easily distinguished because there are several static strings that explains the content + debug_show_all_locks() pr_warn("\nShowing all locks held in the system:\n"); + ftrace_dump(): printk(KERN_TRACE "Dumping ftrace buffer:\n"); The person that enabled the debugging option might know what it did when it process the log the very same day. It might be less clear for others reading the log. Also it still might be convenient to find the beginning easily. Or it might help to orientate when several test runs (over night test) are squashed in a single file. I see such logs pretty often. That said, I do not resist on it. Best Regards, Petr