From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24CFC10F0E for ; Thu, 18 Apr 2019 11:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7845C21850 for ; Thu, 18 Apr 2019 11:18:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="SGzmY92g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388745AbfDRLSr (ORCPT ); Thu, 18 Apr 2019 07:18:47 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:49784 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388457AbfDRLSr (ORCPT ); Thu, 18 Apr 2019 07:18:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MTWvlBGcxn9p8FR3xNRCHkLm1a2gvjsLaACCdCKLnec=; b=SGzmY92ghxsMhmzlBuin913fI /+o5g6YsxrK7Fp5r8fX/4EJ0GcGp9GrtntToMJbYLeqW3dZJDBXvhJ0ItboRp5ZLFTvnXdoN+crY/ gz6AU6iXTqUPJstsFJHxGKv4W4BXHZw9pRE+jd6u6kdmg2QDE3U27rHMrC7vxB8t26Zc3ZiIDiEh1 JgBIvTy1kdkGg0J6VLNDitmFJ6VdDPpIvJH98ytffJbwqg7DU+09yemWAOU4eQuikT8XkxSe09/TY 6+sYhftp+jG99z8NJZQGfvgm4InbKAnYJtpNdqQoxXK2nqjnkCBasoMyOW3Pq53OwOclJdu/jPeBj okUu0Y0tQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH53r-00027y-4L; Thu, 18 Apr 2019 11:18:35 +0000 Date: Thu, 18 Apr 2019 04:18:34 -0700 From: Matthew Wilcox To: Andrew Morton Cc: Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Johannes Weiner , Vlastimil Babka , Roman Gushchin , Christoph Hellwig , Joel Fernandes Subject: Re: [PATCH v4 1/2] mm: refactor __vunmap() to avoid duplicated call to find_vm_area() Message-ID: <20190418111834.GE7751@bombadil.infradead.org> References: <20190417194002.12369-1-guro@fb.com> <20190417194002.12369-2-guro@fb.com> <20190417145827.8b1c83bf22de8ba514f157e3@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190417145827.8b1c83bf22de8ba514f157e3@linux-foundation.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 17, 2019 at 02:58:27PM -0700, Andrew Morton wrote: > On Wed, 17 Apr 2019 12:40:01 -0700 Roman Gushchin wrote: > > +static struct vm_struct *__remove_vm_area(struct vmap_area *va) > > +{ > > + struct vm_struct *vm = va->vm; > > + > > + might_sleep(); > > Where might __remove_vm_area() sleep? > > >From a quick scan I'm only seeing vfree(), and that has the > might_sleep_if(!in_interrupt()). > > So perhaps we can remove this... See commit 5803ed292e63 ("mm: mark all calls into the vmalloc subsystem as potentially sleeping") It looks like the intent is to unconditionally check might_sleep() at the entry points to the vmalloc code, rather than only catch them in the occasional place where it happens to go wrong.