mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Masayoshi Mizuma <msys.mizuma@gmail.com>
Cc: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ktest: introduce REBOOT_RETURN_CODE to confirm the result of REBOOT
Date: Thu, 18 Apr 2019 11:26:07 -0400	[thread overview]
Message-ID: <20190418112607.0923e5df@gandalf.local.home> (raw)
In-Reply-To: <20190418135943.12640-1-msys.mizuma@gmail.com>

On Thu, 18 Apr 2019 09:59:43 -0400
Masayoshi Mizuma <msys.mizuma@gmail.com> wrote:

> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> 
> Unexpected power cycle occurs while the installation of the
> kernel.
> 
>    ssh root@Test sync ... [0 seconds] SUCCESS
>    ssh root@Test reboot ... [1 second] FAILED!
>    virsh destroy Test; sleep 5; virsh start Test ... [6 seconds] SUCCESS
> 
> That is because REBOOT, the default is "ssh $SSH_USER@$MACHINE
> reboot", exits as 255 even if the reboot is successfully done,
> like as:
> 
>    ]# ssh root@Test reboot
>    Connection to Test closed by remote host.
>    ]# echo $?
>    255
>    ]#
> 
> To avoid the unexpected power cycle, introduce a new parameter,
> REBOOT_RETURN_CODE to judge whether REBOOT is successfully done
> or not.
> 

Thanks for sending the patch. I added it to my local queue, and will
use it for testing of my changes to the Linux kernel, and it will
eventually be merged upstream.

-- Steve


      reply	other threads:[~2019-04-18 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 13:59 Masayoshi Mizuma
2019-04-18 15:26 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190418112607.0923e5df@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.mizuma@jp.fujitsu.com \
    --cc=msys.mizuma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®