mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Xin Long <lucien.xin@gmail.com>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Sasha Levin <sashal@kernel.org>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 4.9 05/29] netfilter: bridge: set skb transport_header before entering NF_INET_PRE_ROUTING
Date: Mon, 22 Apr 2019 15:48:24 -0400	[thread overview]
Message-ID: <20190422194848.13049-5-sashal@kernel.org> (raw)
In-Reply-To: <20190422194848.13049-1-sashal@kernel.org>

From: Xin Long <lucien.xin@gmail.com>

[ Upstream commit e166e4fdaced850bee3d5ee12a5740258fb30587 ]

Since Commit 21d1196a35f5 ("ipv4: set transport header earlier"),
skb->transport_header has been always set before entering INET
netfilter. This patch is to set skb->transport_header for bridge
before entering INET netfilter by bridge-nf-call-iptables.

It also fixes an issue that sctp_error() couldn't compute a right
csum due to unset skb->transport_header.

Fixes: e6d8b64b34aa ("net: sctp: fix and consolidate SCTP checksumming code")
Reported-by: Li Shuang <shuali@redhat.com>
Suggested-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
---
 net/bridge/br_netfilter_hooks.c | 1 +
 net/bridge/br_netfilter_ipv6.c  | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c
index 38865deab3ac..0c96773d1829 100644
--- a/net/bridge/br_netfilter_hooks.c
+++ b/net/bridge/br_netfilter_hooks.c
@@ -512,6 +512,7 @@ static unsigned int br_nf_pre_routing(void *priv,
 	nf_bridge->ipv4_daddr = ip_hdr(skb)->daddr;
 
 	skb->protocol = htons(ETH_P_IP);
+	skb->transport_header = skb->network_header + ip_hdr(skb)->ihl * 4;
 
 	NF_HOOK(NFPROTO_IPV4, NF_INET_PRE_ROUTING, state->net, state->sk, skb,
 		skb->dev, NULL,
diff --git a/net/bridge/br_netfilter_ipv6.c b/net/bridge/br_netfilter_ipv6.c
index a1b57cb07f1e..8c08dd07419f 100644
--- a/net/bridge/br_netfilter_ipv6.c
+++ b/net/bridge/br_netfilter_ipv6.c
@@ -235,6 +235,8 @@ unsigned int br_nf_pre_routing_ipv6(void *priv,
 	nf_bridge->ipv6_daddr = ipv6_hdr(skb)->daddr;
 
 	skb->protocol = htons(ETH_P_IPV6);
+	skb->transport_header = skb->network_header + sizeof(struct ipv6hdr);
+
 	NF_HOOK(NFPROTO_IPV6, NF_INET_PRE_ROUTING, state->net, state->sk, skb,
 		skb->dev, NULL,
 		br_nf_pre_routing_finish_ipv6);
-- 
2.19.1


  parent reply	other threads:[~2019-04-22 19:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 19:48 [PATCH AUTOSEL 4.9 01/29] ARM: dts: bcm283x: Fix hdmi hpd gpio pull Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 02/29] s390: limit brk randomization to 32MB Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 03/29] qlcnic: Avoid potential NULL pointer dereference Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 04/29] netfilter: nft_set_rbtree: check for inactive element after flag mismatch Sasha Levin
2019-04-22 19:48 ` Sasha Levin [this message]
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 06/29] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init() Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 07/29] serial: ar933x_uart: Fix build failure with disabled console Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 08/29] usb: gadget: net2280: Fix overrun of OUT messages Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 09/29] usb: gadget: net2280: Fix net2280_dequeue() Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 10/29] usb: gadget: net2272: Fix net2272_dequeue() Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 11/29] ARM: dts: pfla02: increase phy reset duration Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 12/29] net: ks8851: Dequeue RX packets explicitly Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 13/29] net: ks8851: Reassert reset pin if chip ID check fails Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 14/29] net: ks8851: Delay requesting IRQ until opened Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 15/29] net: ks8851: Set initial carrier state to down Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 16/29] staging: rtl8712: uninitialized memory in read_bbreg_hdl() Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 17/29] NFS: Fix a typo in nfs_init_timeout_values() Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 18/29] net: xilinx: fix possible object reference leak Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 19/29] net: ibm: " Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 20/29] net: ethernet: ti: " Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 21/29] scsi: qla4xxx: fix a potential NULL pointer dereference Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 22/29] usb: u132-hcd: fix resource leak Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 23/29] tty: fix NULL pointer issue when tty_port ops is not set Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 24/29] ceph: fix use-after-free on symlink traversal Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 25/29] scsi: zfcp: reduce flood of fcrscn1 trace records on multi-element RSCN Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 26/29] libata: fix using DMA buffers on stack Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 27/29] gpio: of: Fix of_gpiochip_add() error path Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 28/29] kconfig/[mn]conf: handle backspace (^H) key Sasha Levin
2019-04-22 19:48 ` [PATCH AUTOSEL 4.9 29/29] leds: pca9532: fix a potential NULL pointer dereference Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190422194848.13049-5-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=coreteam@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome