From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Guido Kiener <guido@kiener-muenchen.de>,
Guido Kiener <guido.kiener@rohde-schwarz.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Sasha Levin <sashal@kernel.org>,
linux-usb@vger.kernel.org
Subject: [PATCH AUTOSEL 3.18 03/15] usb: gadget: net2272: Fix net2272_dequeue()
Date: Mon, 22 Apr 2019 15:50:10 -0400 [thread overview]
Message-ID: <20190422195022.13760-3-sashal@kernel.org> (raw)
In-Reply-To: <20190422195022.13760-1-sashal@kernel.org>
From: Guido Kiener <guido@kiener-muenchen.de>
[ Upstream commit 091dacc3cc10979ab0422f0a9f7fcc27eee97e69 ]
Restore the status of ep->stopped in function net2272_dequeue().
When the given request is not found in the endpoint queue
the function returns -EINVAL without restoring the state of
ep->stopped. Thus the endpoint keeps blocked and does not transfer
any data anymore.
This fix is only compile-tested, since we do not have a
corresponding hardware. An analogous fix was tested in the sibling
driver. See "usb: gadget: net2280: Fix net2280_dequeue()"
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Guido Kiener <guido.kiener@rohde-schwarz.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
---
drivers/usb/gadget/udc/net2272.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
index 4b2444e75840..83d0544338ca 100644
--- a/drivers/usb/gadget/udc/net2272.c
+++ b/drivers/usb/gadget/udc/net2272.c
@@ -962,6 +962,7 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request *_req)
break;
}
if (&req->req != _req) {
+ ep->stopped = stopped;
spin_unlock_irqrestore(&ep->dev->lock, flags);
return -EINVAL;
}
--
2.19.1
next prev parent reply other threads:[~2019-04-22 19:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 19:50 [PATCH AUTOSEL 3.18 01/15] qlcnic: Avoid potential NULL pointer dereference Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 02/15] usb: gadget: net2280: Fix overrun of OUT messages Sasha Levin
2019-04-22 19:50 ` Sasha Levin [this message]
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 04/15] net: ks8851: Dequeue RX packets explicitly Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 05/15] net: ks8851: Reassert reset pin if chip ID check fails Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 06/15] net: ks8851: Delay requesting IRQ until opened Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 07/15] net: ks8851: Set initial carrier state to down Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 08/15] net: ibm: fix possible object reference leak Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 09/15] scsi: qla4xxx: fix a potential NULL pointer dereference Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 10/15] usb: u132-hcd: fix resource leak Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 11/15] tty: fix NULL pointer issue when tty_port ops is not set Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 12/15] ceph: fix use-after-free on symlink traversal Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 13/15] scsi: zfcp: reduce flood of fcrscn1 trace records on multi-element RSCN Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 14/15] libata: fix using DMA buffers on stack Sasha Levin
2019-04-22 19:50 ` [PATCH AUTOSEL 3.18 15/15] kconfig/[mn]conf: handle backspace (^H) key Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422195022.13760-3-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=guido.kiener@rohde-schwarz.com \
--cc=guido@kiener-muenchen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome