From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEADFC10F11 for ; Mon, 22 Apr 2019 19:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A341C2175B for ; Mon, 22 Apr 2019 19:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962650; bh=eahMSuG4fyAeTweqHpygjje1Vg7DDC7Y7s2E9lMhZS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bVSXRy9yLNzP8ifbCJGUHvU+CGMNblQ/P4X2xG5v9qWDzZN+/8eIyj9f+K97wjhrL DZC0rNPI7uHYplr9Pvw1RodylUBppZqZH54H3EN1XtfTADda/HPVtL8hxcwzFrTqpc 9tOuQNlONdlX3EMsKTtrkiYYrTqbhqtwUQvYT29E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731201AbfDVTut (ORCPT ); Mon, 22 Apr 2019 15:50:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731164AbfDVTun (ORCPT ); Mon, 22 Apr 2019 15:50:43 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8448421738; Mon, 22 Apr 2019 19:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962642; bh=eahMSuG4fyAeTweqHpygjje1Vg7DDC7Y7s2E9lMhZS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DFuuBXU5TIeGXz8jsHKgVwV3ZILYDxXhQm7Fdqlgl170G/1zMAQIRiVpqctpuFO65 ehcDK7ThCnsLldsverTwQSo32ILraD7nOernKK/4E+WNQpQBWrX0m/gA7LNMWAl5Zu MSYxA1ZxpYNYx6D0FH5dZMMVJrr3unx/KGDDifng= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wen Yang , Douglas Miller , "David S. Miller" , netdev@vger.kernel.org, Sasha Levin Subject: [PATCH AUTOSEL 3.18 08/15] net: ibm: fix possible object reference leak Date: Mon, 22 Apr 2019 15:50:15 -0400 Message-Id: <20190422195022.13760-8-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190422195022.13760-1-sashal@kernel.org> References: <20190422195022.13760-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang [ Upstream commit be693df3cf9dd113ff1d2c0d8150199efdba37f6 ] The call to ehea_get_eth_dn returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/ibm/ehea/ehea_main.c:3163:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3154, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Douglas Miller Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 566b17db135a..a718066bb99f 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -3183,6 +3183,7 @@ static ssize_t ehea_probe_port(struct device *dev, if (ehea_add_adapter_mr(adapter)) { pr_err("creating MR failed\n"); + of_node_put(eth_dn); return -EIO; } -- 2.19.1