From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D54F4C282DD for ; Tue, 23 Apr 2019 05:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1265214AE for ; Tue, 23 Apr 2019 05:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555996213; bh=69ba/LcdkGrzPUsyKo78VQP0+UkYmFORyGWlVeZinxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=a4xdVgfNLEwWcS7BpLwELR3PzR3B9xUbc95VaHAajt/nK+K2w2IczMZAxLt7Mwq3j j64vcOAz66tHnMKCy3sCT03qWaesSwBcT2ah8j7aJzSB51H8gebSpPWIItiviG4t7S JIYE4KxshRgBXvzJi2NZrTQjCzaMOMcmfECW+q2c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725977AbfDWFKM (ORCPT ); Tue, 23 Apr 2019 01:10:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:59194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfDWFKL (ORCPT ); Tue, 23 Apr 2019 01:10:11 -0400 Received: from localhost (unknown [171.76.113.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78D9E20811; Tue, 23 Apr 2019 05:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555996211; bh=69ba/LcdkGrzPUsyKo78VQP0+UkYmFORyGWlVeZinxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nW+wFJRM27F8h3lQQMrkZxTcrAi99D4KSeOvOuruSs5/yd1BFadM9ZwyuH84d7dDb inz21vNS6RGC72CnJZKsUVwo/ygvILgKGnqItQ59HWW3TXQnkSdQdP5HTXsa4+1vi7 Bj0u2ttAZWEhctUfP/VsWc107Kb9GTKiUZYInBjk= Date: Tue, 23 Apr 2019 10:40:05 +0530 From: Vinod Koul To: Nicolas Ferre Cc: dmaengine@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org, Alexandre Belloni , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet Message-ID: <20190423051005.GD28103@vkoul-mobl> References: <20190403102359.27698-1-nicolas.ferre@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190403102359.27698-1-nicolas.ferre@microchip.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-04-19, 12:23, Nicolas Ferre wrote: > Even if this case shouldn't happen when controller is properly programmed, > it's still better to avoid dumping a kernel Oops for this. > As the sequence may happen only for debugging purposes, log the error and > just finish the tasklet call. Applied all, thanks -- ~Vinod