From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5F7C10F14 for ; Tue, 23 Apr 2019 06:50:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50728214AE for ; Tue, 23 Apr 2019 06:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556002227; bh=kTol5luT1dQRBw/Ru2EenNrY50TKXdTOZfRy07dOR28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=c1/j16wfXsOBGJ0ZlZGK/OjY22ubaWM6NU2+BgUQKHLrMuqnf+x3zBnj9UnSrZ2MA LpDr7mF5cst4WmkmrixUj+2aOubPAWq8aewWmmCNwVl8fZ/KbXDqSL2ufD9uf4CwdB QK9CtHbnO2BLCF67kFH7JPY6LB5aJ8YWPJt5hErQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbfDWGu0 (ORCPT ); Tue, 23 Apr 2019 02:50:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:58164 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725888AbfDWGuZ (ORCPT ); Tue, 23 Apr 2019 02:50:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8BB55AE32; Tue, 23 Apr 2019 06:50:24 +0000 (UTC) Date: Tue, 23 Apr 2019 08:50:23 +0200 From: Michal Hocko To: Yang Shi Cc: vbabka@suse.cz, rientjes@google.com, kirill@shutemov.name, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: thp: fix false negative of shmem vma's THP eligibility Message-ID: <20190423065023.GA25106@dhcp22.suse.cz> References: <1555971893-52276-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1555971893-52276-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 23-04-19 06:24:53, Yang Shi wrote: > The commit 7635d9cbe832 ("mm, thp, proc: report THP eligibility for each > vma") introduced THPeligible bit for processes' smaps. But, when checking > the eligibility for shmem vma, __transparent_hugepage_enabled() is > called to override the result from shmem_huge_enabled(). It may result > in the anonymous vma's THP flag override shmem's. Hmm, I was under impression that thw global sysfs is not anonymous memory specific and it overrides whatever sysfs comes with. Isn't ignoring the global setting a bug in the shmemfs allocation paths? Kirill what is the actual semantic here? > For example, running a > simple test which create THP for shmem, but with anonymous THP disabled, > when reading the process's smaps, it may show: > > 7fc92ec00000-7fc92f000000 rw-s 00000000 00:14 27764 /dev/shm/test > Size: 4096 kB > ... > [snip] > ... > ShmemPmdMapped: 4096 kB > ... > [snip] > ... > THPeligible: 0 > > And, /proc/meminfo does show THP allocated and PMD mapped too: > > ShmemHugePages: 4096 kB > ShmemPmdMapped: 4096 kB > > This doesn't make too much sense. The anonymous THP flag should not > intervene shmem THP. Calling shmem_huge_enabled() with checking > MMF_DISABLE_THP sounds good enough. And, we could skip stack and > dax vma check since we already checked if the vma is shmem already. Even if I am wrong about the /sys/kernel/mm/transparent_hugepage/enabled being the global setting for _all_ THP then this patch is not sufficient because it doesn't reflect VM_NOHUGEPAGE. > > Fixes: 7635d9cbe832 ("mm, thp, proc: report THP eligibility for each vma") > Cc: Michal Hocko > Cc: Vlastimil Babka > Cc: David Rientjes > Cc: Kirill A. Shutemov > Signed-off-by: Yang Shi > --- > mm/huge_memory.c | 4 ++-- > mm/shmem.c | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 165ea46..5881e82 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -67,8 +67,8 @@ bool transparent_hugepage_enabled(struct vm_area_struct *vma) > { > if (vma_is_anonymous(vma)) > return __transparent_hugepage_enabled(vma); > - if (vma_is_shmem(vma) && shmem_huge_enabled(vma)) > - return __transparent_hugepage_enabled(vma); > + if (vma_is_shmem(vma)) > + return shmem_huge_enabled(vma); > > return false; > } > diff --git a/mm/shmem.c b/mm/shmem.c > index 2275a0f..be15e9b 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3873,6 +3873,8 @@ bool shmem_huge_enabled(struct vm_area_struct *vma) > loff_t i_size; > pgoff_t off; > > + if (test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags)) > + return false; > if (shmem_huge == SHMEM_HUGE_FORCE) > return true; > if (shmem_huge == SHMEM_HUGE_DENY) > -- > 1.8.3.1 > -- Michal Hocko SUSE Labs