From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH next 09/25] input: keyboard: Use dev_get_drvdata()
Date: Tue, 23 Apr 2019 08:44:18 +0000 [thread overview]
Message-ID: <20190423084418.sekqt5jeiqctvofe@penguin> (raw)
In-Reply-To: <20190423075020.173734-10-wangkefeng.wang@huawei.com>
Hi Kefeng,
On Tue, Apr 23, 2019 at 03:50:04PM +0800, Kefeng Wang wrote:
> Using dev_get_drvdata directly.
This assumes that generic device's driver data is exactly the same as platform
device's driver data. This is true today, but does not have to be true
tomorrow.
What is the benefit of violating the layering and accessing "parent"
object's abstraction directly? Performance impact must be negligible...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-04-23 8:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 7:49 [PATCH next 00/25] cleanup: use dev_get_drvdata() directly Kefeng Wang
2019-04-23 7:49 ` [PATCH next 01/25] ACPI / DPTF: Use dev_get_drvdata() Kefeng Wang
2019-05-01 10:13 ` Rafael J. Wysocki
2019-04-23 7:49 ` [PATCH next 02/25] crypto: picoxcell: " Kefeng Wang
2019-05-03 6:09 ` Herbert Xu
2019-04-23 7:49 ` [PATCH next 03/25] dmaengine: " Kefeng Wang
2019-04-26 11:52 ` Vinod Koul
2019-04-28 4:00 ` [PATCH next v2 1/2] dmaengine: bcm-sba-raid: " Kefeng Wang
2019-04-28 4:00 ` [PATCH next v2 2/2] dmaengine: nbpfaxi: " Kefeng Wang
2019-04-29 5:17 ` [PATCH next v2 1/2] dmaengine: bcm-sba-raid: " Vinod Koul
2019-04-23 7:49 ` [PATCH next 04/25] drm/exynos: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 05/25] drm/msm: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 06/25] drm/omap: " Kefeng Wang
2019-05-28 10:57 ` Tomi Valkeinen
2019-04-23 7:50 ` [PATCH next 07/25] hwmon: s3c: " Kefeng Wang
2019-04-23 13:43 ` Guenter Roeck
2019-04-23 7:50 ` [PATCH next 08/25] iio: adc: at91: " Kefeng Wang
2019-04-27 12:07 ` Jonathan Cameron
2019-04-23 7:50 ` [PATCH next 09/25] input: keyboard: " Kefeng Wang
2019-04-23 8:44 ` Dmitry Torokhov [this message]
2019-04-23 7:50 ` [PATCH next 10/25] input: misc: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 11/25] input: mouse: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 12/25] input: touchscreen: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 13/25] iommu/omap: " Kefeng Wang
2019-04-26 14:49 ` Joerg Roedel
2019-04-23 7:50 ` [PATCH next 14/25] mailbox: bcm-flexrm-mailbox: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 15/25] media: platform: " Kefeng Wang
2019-05-24 12:58 ` Mauro Carvalho Chehab
2019-04-23 7:50 ` [PATCH next 16/25] mfd: " Kefeng Wang
2019-05-08 10:32 ` Lee Jones
2019-05-08 13:52 ` [PATCH next v2] " Kefeng Wang
2019-05-09 6:14 ` Lee Jones
2019-05-09 14:23 ` [PATCH next v3] " Kefeng Wang
2019-05-10 7:02 ` Lee Jones
2019-04-23 7:50 ` [PATCH next 17/25] mmc: omap_hsmmc: " Kefeng Wang
2019-04-29 10:45 ` Ulf Hansson
2019-04-23 7:50 ` [PATCH next 18/25] net: can: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 19/25] net: calxedaxgmac: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 20/25] platform/x86: asus-wmi: " Kefeng Wang
2019-05-06 9:01 ` Andy Shevchenko
2019-04-23 7:50 ` [PATCH next 21/25] rtc: " Kefeng Wang
2019-04-26 18:52 ` Alexandre Belloni
2019-04-23 7:50 ` [PATCH next 22/25] media: staging/imx7: " Kefeng Wang
2019-04-23 8:34 ` Rui Miguel Silva
2019-04-23 7:50 ` [PATCH next 23/25] thermal: " Kefeng Wang
2019-04-29 3:47 ` Zhang Rui
2019-04-29 6:55 ` Kefeng Wang
2019-04-23 7:50 ` [PATCH next 24/25] usb: musb: dsps: " Kefeng Wang
2019-04-23 7:50 ` [PATCH next 25/25] video: fbdev: " Kefeng Wang
2019-05-06 13:48 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423084418.sekqt5jeiqctvofe@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®