From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Tao Ren <taoren@fb.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Maxim Mikityanskiy <maximmi@mellanox.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Samuel Mendoza-Jonas" <sam@mendozajonas.com>,
Joel Stanley <joel@jms.id.au>, "Andrew Jeffery" <andrew@aj.id.au>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH net 1/2] net: add eth_addr_inc in etherdevice.h
Date: Tue, 23 Apr 2019 18:24:50 -0700 [thread overview]
Message-ID: <20190423182450.27b403d3@cakuba.netronome.com> (raw)
In-Reply-To: <2b3935f9-fbf9-6baa-570c-dcd6382518c4@fb.com>
On Wed, 24 Apr 2019 00:59:52 +0000, Tao Ren wrote:
> > Please see: Documentation/doc-guide/kernel-doc.rst
> >
> > Here we need:
> > - "()" after function name;
> > - no extra line between function name and argument description.
>
> Thank you for pointing it out (I didn't know the doc-guide). Given I copied the function comment from eth_addr_dec(), I will also fix the format for eth_addr_eth() then.
>
> BTW, "()" is missing from all the other functions' comment in etherdevice.h, so maybe we should fix that in a separate patch?
Possibly, I'm just trying to make sure the new stuff we add follows the
official guidelines :) For the old stuff we need to way it with
potential merge conflicts and muddied git history so the case is not as
clear cut.
next prev parent reply other threads:[~2019-04-24 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 22:41 Tao Ren
2019-04-23 23:15 ` Jakub Kicinski
2019-04-24 0:59 ` Tao Ren
2019-04-24 1:24 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-23 21:20 Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423182450.27b403d3@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=andrew@aj.id.au \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=sam@mendozajonas.com \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®