From: Christian Brauner <christian@brauner.io>
To: Tycho Andersen <tycho@tycho.ws>
Cc: keescook@chromium.org, luto@amacapital.net, jannh@google.com,
linux-kernel@vger.kernel.org, stgraber@ubuntu.com
Subject: Re: SECCOMP_RET_USER_NOTIF: listener improvements
Date: Wed, 24 Apr 2019 17:23:06 +0200 [thread overview]
Message-ID: <20190424152305.32znd5t7r3d3hedj@brauner.io> (raw)
In-Reply-To: <20190424152001.GL3758@cisco>
On Wed, Apr 24, 2019 at 09:20:01AM -0600, Tycho Andersen wrote:
> On Wed, Apr 24, 2019 at 05:04:26PM +0200, Christian Brauner wrote:
> > Hey everyone,
> >
> > So I was working on making use of the seccomp listener stuff and I
> > stumbled upon a problem. Imagine a scenario where:
> >
> > 1. Task T1 installs Filter F1 and gets and listener fd for that filter FD1
> > 2. T1 sends FD1 via SCM_RIGHTS to task T2
> > T2 now holds a reference to the same underlying struct file as FD1 via FD2
> > 3. T2 registers FD2 in an event loop and starts listening for events
> > 4. T1 exits and wipes FD1
> >
> > Now, T2 still holds a reference to the filter via FD2 which references
> > the same underlying file as FD1 which has the seccomp filter stashed in
> > private_data.
> > So T2 will never get notified that the filter is essentially unused and
> > doesn't know when to exit, i.e. it has no way of telling when T1 and all
> > of its children using the same filter are gone.
> >
> > I think we should have a way to do this
>
> Since the only way we ever allow creating a struct file * that points
> to a struct seccomp_filter *, if there is a notifier attached, the
> number of tasks still being monitored by a particular filter should be
> filter->usage - 1 (assuming there is a notifier attached). So we could
> augment __put_seccomp_filter() to check for this and send out a
> message with a SECCOMP_NOTIF_FLAG_DEAD flag or something.
>
> > *or* alternatively have a way to attach a process to an existing
> > filter.
>
> I also think this wouldn't be too hard, since the struct file * has a
> reference to the filter. So I guess the question is: which of these
> makes more sense?
Or we do both... But overall I'm very much in favor of the option to
attach a task to an existing filter. Re-creating a seccomp context is
extremely brittle and error-prone. This would take a way a major pain
point.
Christian
next prev parent reply other threads:[~2019-04-24 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 15:04 Christian Brauner
2019-04-24 15:20 ` Tycho Andersen
2019-04-24 15:23 ` Christian Brauner [this message]
2019-04-24 15:27 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424152305.32znd5t7r3d3hedj@brauner.io \
--to=christian@brauner.io \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=stgraber@ubuntu.com \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®