From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/doc: Allow new UAPI to be used once it's in the driver's -next.
Date: Wed, 24 Apr 2019 21:35:48 +0200 [thread overview]
Message-ID: <20190424193548.GT9857@phenom.ffwll.local> (raw)
In-Reply-To: <20190424185617.16865-1-eric@anholt.net>
On Wed, Apr 24, 2019 at 11:56:16AM -0700, Eric Anholt wrote:
> I was trying to figure out if it was permissible to merge the Mesa
> side of V3D's CSD support yet while it's in drm-misc-next but not
> drm-next, and developers on #dri-devel IRC had differing opinions of
> what the requirement was. Propose a clarification here to see if Dave
> Airlie agrees.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>
> Personally, I thought the rule was "has to be in drm-next", but
> assuming our review processes aren't totally broken, this should be
> enough.
Yeah if you end up with a revert on your hands the process failed much
harder and you get to keep the pieces no matter what. Not sure we should
clarify whether you need a stable sha1 or not (helps with cross
referencing uapi header updates), but imo good as is. And matches what
I've been doing/recommending past few years.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Documentation/gpu/drm-uapi.rst | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index c9fd23efd957..8e5545dfbf82 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -92,8 +92,9 @@ leads to a few additional requirements:
> requirements by doing a quick fork.
>
> - The kernel patch can only be merged after all the above requirements are met,
> - but it **must** be merged **before** the userspace patches land. uAPI always flows
> - from the kernel, doing things the other way round risks divergence of the uAPI
> + but it **must** be merged to the driver's -next tree (as documented in
> + MAINTAINERS) **before** the userspace patches land. uAPI always flows from
> + the kernel, doing things the other way round risks divergence of the uAPI
> definitions and header files.
>
> These are fairly steep requirements, but have grown out from years of shared
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-04-24 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 18:56 Eric Anholt
2019-04-24 18:56 ` [PATCH 2/2] drm/doc: Document expectation that userspace review looks at kernel uAPI Eric Anholt
2019-04-24 19:36 ` Daniel Vetter
2019-05-21 7:47 ` Pekka Paalanen
2019-05-21 8:26 ` Daniel Vetter
2019-04-24 19:35 ` Daniel Vetter [this message]
2019-04-24 20:16 ` [PATCH 1/2] drm/doc: Allow new UAPI to be used once it's in the driver's -next Dave Airlie
2019-04-24 22:06 ` [PATCH 1/2 v2] drm/doc: Allow new UAPI to be used once it's in drm-next/drm-misc-next Eric Anholt
2019-04-25 6:33 ` Daniel Vetter
2019-05-16 16:38 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424193548.GT9857@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®