From: Quentin Perret <quentin.perret@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: mingo@redhat.com, peterz@infradead.org, rui.zhang@intel.com,
linux-kernel@vger.kernel.org, amit.kachhap@gmail.com,
viresh.kumar@linaro.org, javi.merino@kernel.org,
edubezval@gmail.com, daniel.lezcano@linaro.org,
vincent.guittot@linaro.org, nicolas.dechesne@linaro.org,
bjorn.andersson@linaro.org, dietmar.eggemann@arm.com
Subject: Re: [PATCH V2 1/3] Calculate Thermal Pressure
Date: Thu, 25 Apr 2019 11:57:00 +0100 [thread overview]
Message-ID: <20190425105658.q45cmfogrt6wwtih@queper01-ThinkPad-T460s> (raw)
In-Reply-To: <1555443521-579-2-git-send-email-thara.gopinath@linaro.org>
On Tuesday 16 Apr 2019 at 15:38:39 (-0400), Thara Gopinath wrote:
> +/* Per cpu structure to keep track of Thermal Pressure */
> +struct thermal_pressure {
> + unsigned long scale; /* scale reflecting average cpu max capacity*/
> + unsigned long acc_scale; /* Accumulated scale for this time window */
> + unsigned long old_scale; /* Scale value for the previous window */
> + unsigned long raw_scale; /* Raw max capacity */
> + unsigned long age_stamp; /* Last time old_scale was updated */
> + unsigned long last_update; /* Last time acc_scale was updated */
> + spinlock_t lock; /* Lock for protecting from simultaneous access*/
> + /* Timer for periodic update of thermal pressure */
> + struct timer_list timer;
Do you actually need the periodic update ? You only really need to
update the 'scale' value when updating the LB stats no ? Nobody
accesses that value in between two LBs.
Thanks,
Quentin
next prev parent reply other threads:[~2019-04-25 10:57 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 19:38 [PATCH V2 0/3] Introduce " Thara Gopinath
2019-04-16 19:38 ` [PATCH V2 1/3] Calculate " Thara Gopinath
2019-04-18 10:14 ` Quentin Perret
2019-04-24 4:13 ` Thara Gopinath
2019-04-24 16:38 ` Peter Zijlstra
2019-04-24 16:45 ` Peter Zijlstra
2019-04-25 10:57 ` Quentin Perret [this message]
2019-04-25 12:45 ` Vincent Guittot
2019-04-25 12:47 ` Quentin Perret
2019-04-26 14:17 ` Thara Gopinath
2019-05-08 12:41 ` Quentin Perret
2019-04-16 19:38 ` [PATCH V2 2/3] sched/fair: update cpu_capcity to reflect thermal pressure Thara Gopinath
2019-04-16 19:38 ` [PATCH V3 3/3] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2019-04-18 9:48 ` Quentin Perret
2019-04-23 22:38 ` Thara Gopinath
2019-04-24 15:56 ` Ionela Voinescu
2019-04-26 10:24 ` Thara Gopinath
2019-04-25 10:45 ` Quentin Perret
2019-04-25 12:04 ` Vincent Guittot
2019-04-25 12:50 ` Quentin Perret
2019-04-26 13:47 ` Thara Gopinath
2019-04-24 16:47 ` Peter Zijlstra
2019-04-17 5:36 ` [PATCH V2 0/3] Introduce Thermal Pressure Ingo Molnar
2019-04-17 5:55 ` Ingo Molnar
2019-04-17 17:28 ` Thara Gopinath
2019-04-17 17:18 ` Thara Gopinath
2019-04-17 18:29 ` Ingo Molnar
2019-04-18 0:07 ` Thara Gopinath
2019-04-18 9:22 ` Quentin Perret
2019-04-24 16:34 ` Peter Zijlstra
2019-04-25 17:33 ` Ingo Molnar
2019-04-25 17:44 ` Ingo Molnar
2019-04-26 7:08 ` Vincent Guittot
2019-04-26 8:35 ` Ingo Molnar
2019-04-24 15:57 ` Ionela Voinescu
2019-04-26 11:50 ` Thara Gopinath
2019-04-26 14:46 ` Ionela Voinescu
2019-04-29 13:29 ` Ionela Voinescu
2019-04-30 14:39 ` Ionela Voinescu
2019-04-30 16:10 ` Thara Gopinath
2019-05-02 10:44 ` Ionela Voinescu
2019-04-30 15:57 ` Thara Gopinath
2019-04-30 16:02 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425105658.q45cmfogrt6wwtih@queper01-ThinkPad-T460s \
--to=quentin.perret@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nicolas.dechesne@linaro.org \
--cc=peterz@infradead.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®