mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Alban Crequy <alban.crequy@gmail.com>
Cc: john.fastabend@gmail.com, ast@kernel.org, daniel@iogearbox.net,
	bpf@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, alban@kinvolk.io, iago@kinvolk.io
Subject: Re: [PATCH bpf-next v3 1/4] bpf: sock ops: add netns ino and dev in bpf context
Date: Fri, 26 Apr 2019 14:03:23 -0700	[thread overview]
Message-ID: <20190426140323.4edf1127@cakuba.netronome.com> (raw)
In-Reply-To: <20190426154848.23490-1-alban@kinvolk.io>

On Fri, 26 Apr 2019 17:48:45 +0200, Alban Crequy wrote:
> In the unlikely case where network namespaces are not compiled in
> (CONFIG_NET_NS=n), the verifier will not allow access to ->netns_*.

Naive question - why return an error?  init_net should always be there,
no?

  parent reply	other threads:[~2019-04-26 21:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 15:48 Alban Crequy
2019-04-26 15:48 ` [PATCH bpf-next v3 2/4] bpf: sync bpf.h to tools/ for bpf_sock_ops->netns* Alban Crequy
2019-04-26 15:48 ` [PATCH bpf-next v3 3/4] selftests: bpf: read netns_ino from struct bpf_sock_ops Alban Crequy
2019-04-26 15:48 ` [PATCH bpf-next v3 4/4] selftests: bpf: verifier: read netns_dev and " Alban Crequy
2019-04-26 21:03 ` Jakub Kicinski [this message]
2019-04-27 10:48   ` [PATCH bpf-next v3 1/4] bpf: sock ops: add netns ino and dev in bpf context Alban Crequy
2019-04-27 18:39     ` Jakub Kicinski
2019-04-29 15:42       ` Alban Crequy
2019-04-27 16:34 ` Y Song
2019-04-29 15:34   ` Alban Crequy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190426140323.4edf1127@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=alban.crequy@gmail.com \
    --cc=alban@kinvolk.io \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=iago@kinvolk.io \
    --cc=john.fastabend@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®