From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patchwork-bot+notify@kernel.org
Subject: [PATCH 0/2] ASoC: fix hw_params/hw_free validity checks
Date: Mon, 29 Apr 2019 11:47:48 +0200 [thread overview]
Message-ID: <20190429094750.1857-1-jbrunet@baylibre.com> (raw)
While working on a codec, I have found an odd situation. The hw_params
callback which was provided by the codec dai was not called as expected.
However, the hw_free callback was called, even if hw_params was skipped.
After debugging, I found out that the dai was considered invalid because
it did not specify any rates, only rate_min and rate_max. That's a first
problem.
If a codec dai is considered invalid, hw_free should probably not be
called either, that's a 2nd issue.
This patchset is meant to solve both issues.
Jerome Brunet (2):
ASoC: fix valid stream condition
ASoC: skip hw_free on codec dai for which the stream is invalid
sound/soc/soc-pcm.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--
2.20.1
next reply other threads:[~2019-04-29 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 9:47 Jerome Brunet [this message]
2019-04-29 9:47 ` [PATCH 1/2] ASoC: fix valid stream condition Jerome Brunet
2019-05-03 6:18 ` Applied "ASoC: fix valid stream condition" to the asoc tree Mark Brown
2019-05-03 6:21 ` Mark Brown
2019-05-03 6:23 ` Mark Brown
2019-04-29 9:47 ` [PATCH 2/2] ASoC: skip hw_free on codec dai for which the stream is invalid Jerome Brunet
2019-05-03 6:18 ` Applied "ASoC: skip hw_free on codec dai for which the stream is invalid" to the asoc tree Mark Brown
2019-05-03 6:21 ` Mark Brown
2019-05-03 6:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429094750.1857-1-jbrunet@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patchwork-bot+notify@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®