From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D823C43219 for ; Mon, 29 Apr 2019 11:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57ACE20673 for ; Mon, 29 Apr 2019 11:51:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Z/nRoZb3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728046AbfD2LvN (ORCPT ); Mon, 29 Apr 2019 07:51:13 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:47702 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbfD2LvM (ORCPT ); Mon, 29 Apr 2019 07:51:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=j38JudO0qhU870Yr7jDI/6QZJ039LfXF1doZeEZ7TeQ=; b=Z/nRoZb3biXgz/w5MCCNWRTeS xWTSP8tEduOOJuU0KVkn4MTHPPRdNw8urSwBcY4Dxi32FUWESD3Tdwa9XQ6nIjGyEGovvwbshcG2b OZhV22rF9JHCVLHZUebOFaRbQ1qH6R+1Y8H3UWNFzG75Ze/CspFfyrkA35OkazX7vpDk7tb0p4Jn3 qj8RfWXcfNXQJuo8vpTexSwKMCWyIvsgkUBph1S4w+l7Y3g3sHHkA6YWJ8MCYcbHOttJZXOfE1WlW OA1d4EVitpvcZGayfc2Hj510r1MhEJvmiWoMbB/9T7OY9NqeqKk4U4nXmZFQ9q7v6COdedpHrIIqf RW6XmXpfg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hL4oI-00087V-Vz; Mon, 29 Apr 2019 11:51:02 +0000 Date: Mon, 29 Apr 2019 04:51:02 -0700 From: Christoph Hellwig To: Ondrej Zary Cc: Christoph Hellwig , Rik Faith , "David A . Hinds" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/4] fdomain: Resurrect driver (core) Message-ID: <20190429115102.GB25365@infradead.org> References: <20190422173323.15365-1-linux@zary.sk> <20190422173323.15365-2-linux@zary.sk> <20190424060212.GA5506@infradead.org> <201904282152.32077.linux@zary.sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201904282152.32077.linux@zary.sk> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 28, 2019 at 09:52:31PM +0200, Ondrej Zary wrote: > On Wednesday 24 April 2019 08:02:12 Christoph Hellwig wrote: > > > +static void fdomain_work(struct work_struct *work) > > > +{ > > > + struct fdomain *fd = container_of(work, struct fdomain, work); > > > + struct Scsi_Host *sh = container_of((void *)fd, struct Scsi_Host, > > > + hostdata); > > > > This looks odd. We should never need a void cast for container_of. > > This cast is present in all drivers involving container_of, struct Scsi_Host and hostdata. hostdata in struct Scsi_Host is defined as "unsigned long hostdata[0]"... Oh, right - it is the hostdata mess. Sorry for the noise!