From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Jason Gunthorpe <jgg@mellanox.com>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: v5.1-rc7 fails to build on s390x (Re: Linux 5.1-rc7)
Date: Mon, 29 Apr 2019 16:25:18 +0300 [thread overview]
Message-ID: <20190429132518.75nlcixs3zgerv6c@kshutemo-mobl1> (raw)
In-Reply-To: <20190429052136.GA21672@unicorn.suse.cz>
On Mon, Apr 29, 2019 at 07:21:36AM +0200, Michal Kubecek wrote:
> v5.1-rc7 fails to build on s390x due to
>
> vmf->page = ZERO_PAGE(vmf->vm_start);
>
> from commit 67f269b37f9b ("RDMA/ucontext: Fix regression with
> disassociate"). This is not a problem on x86_64 where ZERO_PAGE()
> doesn't use its argument but s390 version does.
>
> I suppose the line should rather read
>
> vmf->page = ZERO_PAGE(vmf->vma->vm_start);
>
> but I'm just guessing.
I belive it has to be
vmf->page = ZERO_PAGE(vmf->address);
--
Kirill A. Shutemov
prev parent reply other threads:[~2019-04-29 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 0:24 Linux 5.1-rc7 Linus Torvalds
2019-04-29 5:21 ` v5.1-rc7 fails to build on s390x (Re: Linux 5.1-rc7) Michal Kubecek
2019-04-29 13:25 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429132518.75nlcixs3zgerv6c@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=jgg@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®