From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D068C43219 for ; Mon, 29 Apr 2019 14:05:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AA0821707 for ; Mon, 29 Apr 2019 14:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556546747; bh=qVipqbpF74NslrIJAp2+g2vf/JWQWFLexrajOnRDUME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oG0v+0C2U2hE66Bb3PpCbZ0cXvxkKc8pQiESXKPMOPyrvXUOBj4VRj1SdVChTBVTf d9tFQ3yjsbcWp/MLD9aaWe3fyWlzxNU+S914z7QgM2ygCEAkFX9EwichbHUCOw59YW VbAifzMyY6/b/ZJdCtldTqc+LNja341DBTKwvMhU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728301AbfD2OFp (ORCPT ); Mon, 29 Apr 2019 10:05:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:55532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728239AbfD2OFp (ORCPT ); Mon, 29 Apr 2019 10:05:45 -0400 Received: from localhost (unknown [171.76.113.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F7F421655; Mon, 29 Apr 2019 14:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556546744; bh=qVipqbpF74NslrIJAp2+g2vf/JWQWFLexrajOnRDUME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p3+1k8xq616yFT7vtr8zz46qwCOa5a6V/y261xa0fS2qnBYuLYJyKsbAYmM7hLitL fjn8DDIuZaH2gGmzjcNxTjXKiK/x1c4nBCPY41rJshPGlL3B1JbdGz1J2YH18KI2J1 vZrKmC68zix+9Akq8rvNGJvMTflpDK+LzAw7mcRU= Date: Mon, 29 Apr 2019 19:35:37 +0530 From: Vinod Koul To: Baolin Wang Cc: Dan Williams , eric.long@unisoc.com, Orson Zhai , Chunyan Zhang , Mark Brown , dmaengine@vger.kernel.org, LKML Subject: Re: [PATCH 4/7] dmaengine: sprd: Add device validation to support multiple controllers Message-ID: <20190429140537.GN3845@vkoul-mobl.Dlink> References: <20190429115723.GK3845@vkoul-mobl.Dlink> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-04-19, 20:20, Baolin Wang wrote: > On Mon, 29 Apr 2019 at 19:57, Vinod Koul wrote: > > > > On 15-04-19, 20:14, Baolin Wang wrote: > > > From: Eric Long > > > > > > Since we can support multiple DMA engine controllers, we should add > > > device validation in filter function to check if the correct controller > > > to be requested. > > > > > > Signed-off-by: Eric Long > > > Signed-off-by: Baolin Wang > > > --- > > > drivers/dma/sprd-dma.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > > > index 0f92e60..9f99d4b 100644 > > > --- a/drivers/dma/sprd-dma.c > > > +++ b/drivers/dma/sprd-dma.c > > > @@ -1020,8 +1020,13 @@ static void sprd_dma_free_desc(struct virt_dma_desc *vd) > > > static bool sprd_dma_filter_fn(struct dma_chan *chan, void *param) > > > { > > > struct sprd_dma_chn *schan = to_sprd_dma_chan(chan); > > > + struct of_phandle_args *dma_spec = > > > + container_of(param, struct of_phandle_args, args[0]); > > > u32 slave_id = *(u32 *)param; > > > > > > + if (chan->device->dev->of_node != dma_spec->np) > > > > Are you not using of_dma_find_controller() that does this, so this would > > be useless! > > Yes, we can use of_dma_find_controller(), but that will be a little > complicated than current solution. Since we need introduce one > structure to save the node to validate in the filter function like > below, which seems make things complicated. But if you still like to > use of_dma_find_controller(), I can change to use it in next version. Sorry I should have clarified more.. of_dma_find_controller() is called by xlate, so you already run this check, so why use this :) -- ~Vinod