From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF36C43219 for ; Mon, 29 Apr 2019 18:01:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B6C5215EA for ; Mon, 29 Apr 2019 18:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556560864; bh=sFFvyA44VXeP1wLbbZvgidVaXfv7KuL0Resa1TofAm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=aoNj7nq5WRUVKVthG94xZrsfPqDbWylu7/PwS/hnanvrQ78RSLOcYkJ0QJ/ZoL5sg mlW31v8FYKQQTkgWW7R3aNRhkSf0Uey9Z9/DQW5oRItcnF0ccyeU29G7p+hcIMFExR eE0RHc3YGdBsfCHNboKzhMsB1uufpEJVlt16gFeo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729024AbfD2SBC (ORCPT ); Mon, 29 Apr 2019 14:01:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:57664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728748AbfD2SBC (ORCPT ); Mon, 29 Apr 2019 14:01:02 -0400 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF0C72087B; Mon, 29 Apr 2019 18:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556560861; bh=sFFvyA44VXeP1wLbbZvgidVaXfv7KuL0Resa1TofAm8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MAp8qyacJLIBsKGrAXal5dB1/ae0L5bzzKoIZa+jw6CT4mZwsnYcm1HSI1ZWvIJCj JsUcbIoip2yKM4CJJ9rFqkG0pIPTKSlXgeF3YcsEQZE1bq8JjAgavJ28U6RGfuAM5j BLoZ+EdXBEt+np1KeQ+NkhlTq1uHrdW3N20vOQtE= Date: Mon, 29 Apr 2019 21:00:55 +0300 From: Leon Romanovsky To: Doug Ledford Cc: Linus Torvalds , linux-rdma , linux-kernel , "Gunthorpe, Jason" Subject: Re: [GIT PULL] Please pull rdma.git Message-ID: <20190429180055.GX6705@mtr-leonro.mtl.com> References: <48cbd548d153d1d2a1cf6c4f2127a6cef5d55deb.camel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 29, 2019 at 01:13:01PM -0400, Doug Ledford wrote: > On Mon, 2019-04-29 at 09:48 -0700, Linus Torvalds wrote: > > On Mon, Apr 29, 2019 at 9:29 AM Doug Ledford wrote: > > > > > > drivers/infiniband/core/uverbs_main.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > This trivial one-liner is actually incorrect. > > > > It should use 'vmf->address', because the point of the ZERO_PAGE > > argument is to pick the page with the right virtual address alias for > > broken architectures that need those kinds. > > > > I'm actually surprised s390 wants it, usually it's just MIPS that has > > the horribly broken virtual address translation stuff. But it looks > > like for s390 it's at least only a performance issue (ie it causes > > some aliases in L1 that cause cacheline ping-pong rather than anything > > else). > > That's what I get for listening to Jason ;-) > > Well, since you have just essentially re-written the patch to be > correct, you are now the developer of origin. Do you want to commit the > fix directly or shall I respin it for you to pull? Linus already committed it. The whole breakage is mystery for me, the patch which introduced breakage, got successful build report from 0-build. Thanks > > -- > Doug Ledford > GPG KeyID: B826A3330E572FDD > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcxzvXAAoJEORje4g2clinNg0P/04kAMArpOP6S4eKNROZLfoO wgoAQXtUOrLXPlcEmi4fbZ7N254b/PxHaXx0PAXu8xdnGZ263KYByRbzTK4WqWH5 RpPEdQGbi1wwGBxnycsxhubJBFZxjULjQNivOBEq1tpQ8jjgBsIp1QfmX5j5Vq+P TexksU4wpTs4/XEaJWwEaThHeVnk/wW4W7MeSc52qkgU0UI1V2ziuaMOneZ4xk7j 2F4QsyCV4dU2VWYuu9Y76e14sQ8nKV7cvL5uTfiQ6Y9jhTKwnLJGQWCbR+gM2pAf s9b/U9l/izJwjD+P1U+bwAjLZEJv5SzXziZuzSnRzYi8lkaF9lC4Crz4LSHDNcPv pX9ooUfMDBAczvSG2wDUhhohSB4cPBu74ZkOO4u7aWq6tM2XzE0VFqErSQJ80wIk 6DRNqrtR1l7z50lrSbSaRcG8UpHZDScsPBk88Fw5HDDuptZqMnZz6dwXekDbNdNT R4VO508NMLIVlfpkjHc5Qs0ieeiclwt4NQt+PpkR02lm1U443hQFGViVsHZD3mQU 8GppR/rHJRX0aUUEaFVDhQkkwud85cyUQVtkqSCPW0oK1+TpGEKwV6R80Pe+MBwC LPCHK9Pn3hK1aiFXOYkc22LT3ubG+Ga081c0PqUH8toCCveXBas11u2Q/eWvVW5D yzkWI2tDNdY+l99ak7s6 =5kYY -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--