From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E499BC43219 for ; Mon, 29 Apr 2019 22:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99541215EA for ; Mon, 29 Apr 2019 22:40:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="RdBjZZoR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729647AbfD2Wki (ORCPT ); Mon, 29 Apr 2019 18:40:38 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:17837 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfD2Wkh (ORCPT ); Mon, 29 Apr 2019 18:40:37 -0400 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20190429224035epoutp019ed72e4202f1a16fdab7c994b2faa80d~aExyrh6cd1116611166epoutp01K for ; Mon, 29 Apr 2019 22:40:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20190429224035epoutp019ed72e4202f1a16fdab7c994b2faa80d~aExyrh6cd1116611166epoutp01K DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1556577635; bh=efZDE7R8MR8F+5XY1yFe+Tw7lt5nUY6FngkwLfh921o=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=RdBjZZoRhfSMRVt4yK5AuamaNf2cHxpkSaLPIXFzF/rozP924iN/M/UKiQ360SjPZ DC+eb5TGE+QXQXnYA+5ro2D640rm0MzWJ/tVdOeY1Lm7AJpJ+aOo9TlQmk6ufm+LzB 0ugyLYE2r7jqbVV7jKgcmihFH7vOkudFJiHbyBVo= Received: from epsmges2p3.samsung.com (unknown [182.195.40.181]) by epcas2p2.samsung.com (KnoxPortal) with ESMTP id 20190429224032epcas2p2cb3d89cbb8a3cdcd5ee1e109a18cbabe~aExwZYewN2600226002epcas2p2P; Mon, 29 Apr 2019 22:40:32 +0000 (GMT) X-AuditID: b6c32a47-133ff7000000106e-98-5cc77d602ba2 Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id A5.BD.04206.06D77CC5; Tue, 30 Apr 2019 07:40:32 +0900 (KST) Mime-Version: 1.0 Subject: RE: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings Reply-To: minwoo.im@samsung.com From: Minwoo Im To: Chaitanya Kulkarni , Minwoo Im , Minwoo Im CC: "linux-kernel@vger.kernel.org" , Christoph Hellwig , "linux-nvme@lists.infradead.org" , Sagi Grimberg X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20190429224031epcms2p45b9198075ea9406da495a1b813400a0d@epcms2p4> Date: Tue, 30 Apr 2019 07:40:31 +0900 X-CMS-MailID: 20190429224031epcms2p45b9198075ea9406da495a1b813400a0d Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH++3O7WqursvqZFTrir3I3LU2b6EmJXkhLakwqJVd9IeT9mJ3 hgWioyK1KIWeS12EZWkPMktrULJekJa9oHxS0dPloheUYrXrndR/Hw7fc77ne34/klAfV0SR +RYHtlt4E60Ik1+9NVcfu6XonkFb7QtlXd0+OXu24Y6MfXq9SsG6T79VsoNlY9l3ba0Ee8H3 WZ6i5K65epVcR98lOXe5tpjzdJYouP1N9Yj71jid29O6V5ap3GBKNGI+F9s12JJjzc235CXR K9dmL8/W6bVMLLOYTaA1Ft6Mk+jU9MzYFfmmwDq0ZhtvKgiUMnlBoOOSE+3WAgfWGK2CI4nG tlyTjWFsCwTeLBRY8hbkWM1LGK02XhdQbjEZ2w51ELYn4wvfDHlQCfKHl6NQEqhF8P78NaIc hZFqqgXBx08eWTkiSRUVAcMtE0TNBGoJHDy2E4llNTUDfvZrpfJc8HvaQ0RWULOh5FC/XORI qgj8DbeROJKg7iOobX0cInmp4Oiet3KJp0Jz3RUkcii1Cbp+f1dI9YnQ2TCgHOXPd91I4kjY 3feAkDgCXv7yjOwDFECfP1nCYmg6w4q2QO1C8OLT+WBrHDjffxmxVVEZ0OnZJxNZTsVA63Bn UJMK5272jGiIQMTmgSpCnEkEMl68HieNj4bbXUHFOCi9NawcDdVS80YmcTR88XqDS06Buie+ YCgOnu16rZCO/BWBr7kbVSCN69+dXf8Zu/4Zn0BEPZqEbYI5DwvxtoX/P20jGvmY89Ja0NWH 6V5EkYgOV3H+uwZ1CL9N2G72IiAJOlLF3btjUKty+e07sN2abS8wYcGLdIH8lUTUxBxr4Jtb HNmMLl6v1y7WsTp9PEtPVr2aWr1RTeXxDrwVYxu2j/bJyNCoEqT7fXxK1nNPr9PWv86w4hsu xcNneth248xZDDqVkrqxa/7ZjDlLPZM3PHtXFXNpf/KNxnRne23FySF34s+e1Yb0mur13sJl P8rqICGrw9nbkZK2JmYfM62wbcxg2MIPR0y62e3uB4+sA94/7uqsjLpVys1RM5zdr51Fj4mE A4ezKmm5YOSZeYRd4P8CtzEFLK4DAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20190429221427epcas3p2ff4fc6e3b8da00a34cf5766b6f2754f5 References: <201904300131.gB7Qr2Ik%lkp@intel.com> <20190429175734.GA20932@lkp-kbuild08> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sure, I will. Thanks, > -----Original Message----- > From: Linux-nvme [mailto:linux-nvme-bounces@lists.infradead.org] On > Behalf Of Chaitanya Kulkarni > Sent: Tuesday, April 30, 2019 7:14 AM > To: Minwoo Im > Cc: linux-kernel@vger.kernel.org; Christoph Hellwig; linux- > nvme@lists.infradead.org; Sagi Grimberg > Subject: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings > > Hi Minwoo, > > Can you please resend this patch with the suggested change ? > > On 04/29/2019 10:58 AM, kbuild test robot wrote: > > From: kbuild test robot > > > > drivers/nvme/target/discovery.c:375:1-3: WARNING: PTR_ERR_OR_ZERO > can be used > > > > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > > > Fixes: 6b7e631b927c ("nvmet: return a specified error it subsys_alloc fails") > > CC: Minwoo Im > > Signed-off-by: kbuild test robot > > --- > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > > head: 3d17a1de96a233cf89bfbb5a77ebb1a05c420681 > > commit: 6b7e631b927ca1266b2695307ab71ed7764af75e [9188/10649] > nvmet: return a specified error it subsys_alloc fails > > > > discovery.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > --- a/drivers/nvme/target/discovery.c > > +++ b/drivers/nvme/target/discovery.c > > @@ -372,9 +372,7 @@ int __init nvmet_init_discovery(void) > > { > > nvmet_disc_subsys = > > nvmet_subsys_alloc(NVME_DISC_SUBSYS_NAME, > NVME_NQN_DISC); > > - if (IS_ERR(nvmet_disc_subsys)) > > - return PTR_ERR(nvmet_disc_subsys); > > - return 0; > > + return PTR_ERR_OR_ZERO(nvmet_disc_subsys); > > } > > > > void nvmet_exit_discovery(void) > > > > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme