Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

[Vinod Koul <vkoul@kernel.org>]

On 19-04-19, 12:14, Pierre-Louis Bossart wrote:
> 
> > > >   enum sdw_command_response
> > > >   cdns_xfer_msg_defer(struct sdw_bus *bus,
> > > > -        struct sdw_msg *msg, struct sdw_defer *defer)
> > > > +            struct sdw_msg *msg, struct sdw_defer *defer)
> > > 
> > > this one too..
> > > 
> > > >   static int cdns_port_params(struct sdw_bus *bus,
> > > > -        struct sdw_port_params *p_params, unsigned int bank)
> > > > +                struct sdw_port_params *p_params, unsigned int bank)
> > > 
> > > here as well.. (and giving up on rest)
> > 
> > Please check for yourself that this is a diff illusion w/ tab space.
> 
> Vinod, can you please double-check, the alignment issues you reported don't
> exist, see e.g. below what the code looks like after merge.
> 
> 
> int sdw_transfer_defer(struct sdw_bus *bus, struct sdw_msg *msg,
>                        struct sdw_defer *defer)
> 
> int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave,
>                  u32 addr, size_t count, u16 dev_num, u8 flags, u8 *buf)

Sure, please split up as requested and I shall test apply and check
alignment before reporting...

-- 
~Vinod