From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E636C43219 for ; Tue, 30 Apr 2019 11:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2748921707 for ; Tue, 30 Apr 2019 11:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbfD3LG3 (ORCPT ); Tue, 30 Apr 2019 07:06:29 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:44526 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbfD3LG3 (ORCPT ); Tue, 30 Apr 2019 07:06:29 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0A0180D; Tue, 30 Apr 2019 04:06:28 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 40C353F5C1; Tue, 30 Apr 2019 04:06:27 -0700 (PDT) Date: Tue, 30 Apr 2019 12:06:24 +0100 From: Will Deacon To: Arun KS Cc: Catalin Marinas , James Morse , Mark Rutland , Jun Yao , Steve Capper , Vladimir Murzin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: arm64: Fix size of __early_cpu_boot_status Message-ID: <20190430110624.GB16204@fuggles.cambridge.arm.com> References: <1556620535-10060-1-git-send-email-arunks@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556620535-10060-1-git-send-email-arunks@codeaurora.org> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 04:05:04PM +0530, Arun KS wrote: > __early_cpu_boot_status is of type long. Use quad > assembler directive to allocate proper size. > > Signed-off-by: Arun KS > --- > arch/arm64/kernel/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index eecf792..115f332 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -684,7 +684,7 @@ ENTRY(__boot_cpu_mode) > * with MMU turned off. > */ > ENTRY(__early_cpu_boot_status) > - .long 0 > + .quad 0 Yikes. How did you spot this? Did we end up corrupting an adjacent variable, or does the alignment in the linker script save us in practice? Will