From: Vinod Koul <vkoul@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@lists.codethink.co.uk,
Dmitry Osipenko <digetx@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: tegra: add accurate reporting of dma state
Date: Wed, 1 May 2019 18:43:27 +0530 [thread overview]
Message-ID: <20190501131327.GX3845@vkoul-mobl.Dlink> (raw)
In-Reply-To: <71198258-40b8-3f7f-1401-58513bfaaab5@nvidia.com>
On 01-05-19, 09:33, Jon Hunter wrote:
> > @@ -1444,12 +1529,7 @@ static int tegra_dma_probe(struct platform_device *pdev)
> > BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) |
> > BIT(DMA_SLAVE_BUSWIDTH_8_BYTES);
> > tdma->dma_dev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> > - /*
> > - * XXX The hardware appears to support
> > - * DMA_RESIDUE_GRANULARITY_BURST-level reporting, but it's
> > - * only used by this driver during tegra_dma_terminate_all()
> > - */
> > - tdma->dma_dev.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT;
> > + tdma->dma_dev.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
> > tdma->dma_dev.device_config = tegra_dma_slave_config;
> > tdma->dma_dev.device_terminate_all = tegra_dma_terminate_all;
> > tdma->dma_dev.device_tx_status = tegra_dma_tx_status;
>
> In addition to Dmitry's comments, can you please make sure you run this
> through checkpatch.pl?
And use correct subsystem name !
--
~Vinod
prev parent reply other threads:[~2019-05-01 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 16:23 Ben Dooks
2019-04-24 18:17 ` Dmitry Osipenko
2019-05-01 8:58 ` Ben Dooks
2019-05-04 16:06 ` Dmitry Osipenko
2019-05-05 13:39 ` Dmitry Osipenko
2019-06-12 18:57 ` Dmitry Osipenko
2019-05-01 8:33 ` Jon Hunter
2019-05-01 13:13 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501131327.GX3845@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=dan.j.williams@intel.com \
--cc=digetx@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®