From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F40C43219 for ; Thu, 2 May 2019 01:31:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A815206DF for ; Thu, 2 May 2019 01:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556760664; bh=ur9DF3hKCoRuZMcLVEItK2+G/8oBBRntd47mJXWbxiA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KluuUhuMrlckbh9s5YVOiBMM901RNEzixYY4/3dWxWgDhpIEeJYXugHNkISQljZLf +ii+GqYz2k4xPzfK9lNmgrp+9GAkqn3KPNeMNfBDj1rr8ksQkOXAiOugX1h8DNsjcc TZd2fJWNO7YvUWv260k+IW3XOqi0edk+tmIJNgw8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbfEBBbC (ORCPT ); Wed, 1 May 2019 21:31:02 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:60156 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbfEBBbC (ORCPT ); Wed, 1 May 2019 21:31:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BtxNJuTi7c3Tm7Seqwv07Ixzy3v5k8zXO4yysFcyrAY=; b=n7KTPS7Hip3Do1cImIfuzKRoF gp6miykBujjShJmfKLlbPRC6vUFMYma5H2cjMLsrAZ+X+Mei+o6wobozcDXhNwAXHSR3St4H9ozjU +riBDVgyCwoNO5BQewK98McYRpfI0xXa7favAXRhawPvaB2Oz2DHyrJwQRfackEy7K2ZI=; Received: from [211.55.52.15] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hM0YN-0005QG-Gf; Thu, 02 May 2019 01:30:27 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 7C2EB441D3B; Thu, 2 May 2019 02:30:22 +0100 (BST) Date: Thu, 2 May 2019 10:30:22 +0900 From: Mark Brown To: Adam Thomson Cc: Liam Girdwood , Takashi Iwai , Jaroslav Kysela , Akshu Agrawal , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Support Opensource Subject: Re: [PATCH] ASoC: da7219: Use clk_round_rate to handle enabled bclk/wclk case Message-ID: <20190502013022.GN14916@sirena.org.uk> References: <20190426125925.04F3F3FB4A@swsrvapps-01.diasemi.com> <20190427171955.GH14916@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TN8pJM9vJMHHFgJc" Content-Disposition: inline In-Reply-To: X-Cookie: -- I have seen the FUN -- User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --TN8pJM9vJMHHFgJc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 29, 2019 at 09:16:08AM +0000, Adam Thomson wrote: > On 27 April 2019 18:20, Mark Brown wrote: > > Don't we need to validate that the rounded rate is actually viable for > > the parameters we're trying to set here? If there's missing constraints > > causing something to try to do something unsupportable then we should > > return an error rather than silently accept. > Thanks for directing my gaze to this again. Actually I don't think the SR should > be rounded at all. If it doesn't match exactly it should fail so I'll remove the > rounding here. Not sure what my brain was doing there. Yeah, rounding is dubious with sample rate. Many applications will be able to tolerate *some* variation as there's tolerances in the crystals if nothing else but intentionally allowing it is a bit different. --TN8pJM9vJMHHFgJc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlzKSCsACgkQJNaLcl1U h9DXvAf+P9971wrO2YV773UVMXkelPV+MmTYvPVA/VL4bLD1Mg7EU4Q42Xm2TrC+ p6me4v618rDTK6qjyHbVW2naAgUgMEMYWmY53WO50rDBM6CcmLdpp0U0jqZTd2La /fVKdYNXJf3ZUpoe6OqJ05GpD/Ah3yq4iEdCTHCkiEjsRuSO3PbZxZvlU6QqOXeJ doBoeBlBU0XT/bjO/W9tzUUVQFtBQWHG19mzuSosxosl4AVMjBzajSITE9QsjGQE 0xRfb1ClDpLFyypsOBhM7cuTuPCcnJvWHbJeKy8lrr8TpZ+LE0AxRLUX/d5oLdqN 0Z+RhTSeFWZpThbExo/oc9/sqBSDaA== =XOH+ -----END PGP SIGNATURE----- --TN8pJM9vJMHHFgJc--