From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B04F9C43219 for ; Thu, 2 May 2019 02:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76E1D20645 for ; Thu, 2 May 2019 02:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556764891; bh=ZgLoO18O53ZuU2G3ua7/tfSxAzV5wTxeEA7xVnN9JaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Biqw4xGXic3mkCdXCQuSWtTqSjH2j2XQTXtZ4uLqnLP3plEdfn2dTfaO82V5Gn1H5 xkwNBJ/3DwTt0HkJ/fdTuwFvo/StxCYUmoPYDFYzq6M9DgudIHad2xHSnYIugkHIgX /THzT2ZiRAf2LoDiV4EDUD0OkNnXOGw4KJ75wlyU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbfEBCla (ORCPT ); Wed, 1 May 2019 22:41:30 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:37966 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbfEBCla (ORCPT ); Wed, 1 May 2019 22:41:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5ObYVRU0Kf3pIITjmag/DPVZ4iVx1mDoeKshyHfJ4vg=; b=cUEDpZHpMZfUfljvsKyxjzbES jWRaGxO3R9a3EdC2DaCtHkS9Vhdxvktq3aB9nQfImncj6KC4FS8w8k+EY4u1TSJ+yKAxodqr/Wbav JahLkMP6xJ8NFsNMUrUarbZBLbsRy374CbDweYt3y7gyTLMbbOEa6m0S6GHXl5Ay87bak=; Received: from [211.55.52.15] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hM1el-00060N-6I; Thu, 02 May 2019 02:41:07 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 0FB6D441D3C; Thu, 2 May 2019 03:41:04 +0100 (BST) Date: Thu, 2 May 2019 11:41:04 +0900 From: Mark Brown To: masonccyang@mxic.com.tw Cc: bbrezillon@kernel.org, christophe.kerello@st.com, computersforpeace@gmal.com, devicetree@vger.kernel.org, dwmw2@infradead.org, geert@linux-m68k.org, juliensu@mxic.com.tw, lee.jones@linaro.org, liang.yang@amlogic.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, marcel.ziswiler@toradex.com, marek.vasut@gmail.com, mark.rutland@arm.com, miquel.raynal@bootlin.com, paul.burton@mips.com, richard@nod.at, robh+dt@kernel.org, stefan@agner.ch, zhengxunli@mxic.com.tw Subject: Re: [PATCH v3 3/4] spi: Patch Macronix SPI controller driver according to MX25F0A MFD driver Message-ID: <20190502024103.GT14916@sirena.org.uk> References: <1555320234-15802-1-git-send-email-masonccyang@mxic.com.tw> <1555320234-15802-4-git-send-email-masonccyang@mxic.com.tw> <20190419145151.GR2803@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="U2mKMzaWgYxzMy3/" Content-Disposition: inline In-Reply-To: X-Cookie: -- I have seen the FUN -- User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --U2mKMzaWgYxzMy3/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 30, 2019 at 06:23:21PM +0800, masonccyang@mxic.com.tw wrote: > > It'd be much better to describe what the above actually means - what > > changes have been made in the introduction of the MFD driver? It does > > feel like there's not as much abstraction as I'd expect between the MFD > > and the child, there's a lot of peering into the parent and enabling and > > disabling individual clocks for example rather than either having this > > hidden behind a function or just having the clocks owned by the child > > driver.=20 > Do you mean I should remove ps_clk/send_clk/send_dly_clk resource from MF= D=20 > and patch them to spi-mxic.c ? > Or any other ? I think you need to have a clear idea that you can explain as to what the MFD is and how it's split up. What's being abstracted, what's not and why. Without knowing anything about the device or what the series is trying to accomplish it's hard to be sure exactly what the best thing to do is. > The driver also isn't using the MFD interfaces to pass through > > the register subblocks for the IP - instead the child driver is peering > > straight into the MFD structure and looking at a variable in there. > Patch regmap for mfd, nand and spi ? > or any other patches is needed ? This is a memory mapped device so there should be no need to use regmap unless you want to. The MFD subsystem has facilities for passing through memory regions to subdevices. --U2mKMzaWgYxzMy3/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlzKWL8ACgkQJNaLcl1U h9AjiQf/bW7XYR+RCtB5mk7NUhGOFWv7c4gcOImzc4a6QObhKLrSolCYsj2RWhcl Gnq+EA50PHXQZqZMl6tLN7skgu1q8gHz79mwbns4pqSQtAC5Uw5PU2MWGMpBkBXl lx4jDU7D7JmlCkkbWCOb9mi/Rhq4AAbn4yWSd4ZN+3FC2znx8HY9x/12257saaV8 ndBNuyLQdAWw8oz5cIpcLU7w+YaEYcT6qHbTbmfRBdCyIfKTxVOwq403UnLSjKW6 LU90b3lGa1zs5IP2m6rKwRCggfZnkgjvrRl9VQJXPxx3Ggyj7jG1OKBa7ia0Kf/a QZsQU1oxCxD+GUVGvbJkybiuRYKmxw== =TLm4 -----END PGP SIGNATURE----- --U2mKMzaWgYxzMy3/--