From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD0A6C43219 for ; Thu, 2 May 2019 06:32:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADC712089E for ; Thu, 2 May 2019 06:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556778743; bh=h6lQUZAXWXjVncrTfdjGeEblQS97dkVgyYPRpZ8VW90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Eer2spVbZPqwyW//t/Uo82MRFi+hPz3LFp/qvKyCF2tTwOtXGvsv1w9W0TOK73KrR Q+wywXzsXxKIpObLMJ8rfzLeBzcvaaoek/K5e9yGQpbVszOLY/mSanzK6geSrB+9uM VrCLnRXQ8RKoG+J1nqh+NR1cf4yn8txJHAx04QaM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfEBGcW (ORCPT ); Thu, 2 May 2019 02:32:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:56108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725764AbfEBGcW (ORCPT ); Thu, 2 May 2019 02:32:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C63620873; Thu, 2 May 2019 06:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556778741; bh=h6lQUZAXWXjVncrTfdjGeEblQS97dkVgyYPRpZ8VW90=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hBBk4E5Ylzod4E003AbqFlC3AvaC8ABsCM4IbQ7pySzcD9tZpd7Y9fFvgxpkyzf76 uWYvzldvXXUoG+f1ErefYkAdl4EzYp40H5KClfPuxxJQbn92Kf0JY/ynkoGWqxitpX ard7zdwZUgqVgFHTgTHUG4NnS3ytXlg0D5HTTvuw= Date: Thu, 2 May 2019 08:32:19 +0200 From: Greg KH To: Vinod Koul Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, liam.r.girdwood@linux.intel.com, jank@cadence.com, joe@perches.com, srinivas.kandagatla@linaro.org, Sanyog Kale Subject: Re: [PATCH v4 22/22] soundwire: add missing newlines in dynamic debug logs Message-ID: <20190502063219.GB14347@kroah.com> References: <20190501155745.21806-1-pierre-louis.bossart@linux.intel.com> <20190501155745.21806-23-pierre-louis.bossart@linux.intel.com> <20190502053746.GE3845@vkoul-mobl.Dlink> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502053746.GE3845@vkoul-mobl.Dlink> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 11:07:46AM +0530, Vinod Koul wrote: > On 01-05-19, 10:57, Pierre-Louis Bossart wrote: > > For some reason the newlines are not used everywhere. Fix as needed. > > > > Reported-by: Joe Perches > > Reviewed-by: Takashi Iwai > > Signed-off-by: Pierre-Louis Bossart > > --- > > drivers/soundwire/bus.c | 74 +++++++++---------- > > drivers/soundwire/cadence_master.c | 12 ++-- > > drivers/soundwire/intel.c | 12 ++-- > > drivers/soundwire/stream.c | 110 ++++++++++++++--------------- > > Sorry this needs to be split up. I think bus.c and stream.c should go > in patch with cadence_master.c and intel.c in different ones Again, _way_ too picky. You can't look a gift horse _too_ closely in the mouth... greg k-h