From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01813C43219 for ; Thu, 2 May 2019 07:15:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D067B20873 for ; Thu, 2 May 2019 07:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbfEBHP0 (ORCPT ); Thu, 2 May 2019 03:15:26 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57247 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbfEBHP0 (ORCPT ); Thu, 2 May 2019 03:15:26 -0400 X-Originating-IP: 90.88.149.145 Received: from localhost (aaubervilliers-681-1-29-145.w90-88.abo.wanadoo.fr [90.88.149.145]) (Authenticated sender: maxime.ripard@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A896520003; Thu, 2 May 2019 07:15:21 +0000 (UTC) Date: Thu, 2 May 2019 09:15:21 +0200 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Michael Trimarchi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, linux-sunxi@googlegroups.com Subject: Re: [PATCH v4 1/3] arm64: dts: allwinner: a64: Move I2C pinctrl to dtsi Message-ID: <20190502071521.7ekih3bgjth54sry@flea> References: <20190418174720.17230-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l3fjic7vuxbz5vss" Content-Disposition: inline In-Reply-To: <20190418174720.17230-1-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --l3fjic7vuxbz5vss Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Thu, Apr 18, 2019 at 11:17:18PM +0530, Jagan Teki wrote: > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts > index f4e78531f639..bef4abf6fa25 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts > @@ -121,8 +121,6 @@ > > /* i2c1 connected with gpio headers like pine64, bananapi */ > &i2c1 { > - pinctrl-names = "default"; > - pinctrl-0 = <&i2c1_pins>; > status = "disabled"; > }; That node can be removed entirely It looks fine otherwise. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --l3fjic7vuxbz5vss Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXMqZCQAKCRDj7w1vZxhR xU9OAQDxTAEtGhuPzyZjpKPIGQXLaALohb8tDqQ5pCkcRraUIQEAvx/AzS8BBrHq CikCMIi3e4lw8EMelHNzyKK0j78UpQc= =gnAK -----END PGP SIGNATURE----- --l3fjic7vuxbz5vss--