From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6217C43219 for ; Thu, 2 May 2019 07:39:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FDF920873 for ; Thu, 2 May 2019 07:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfEBHjI (ORCPT ); Thu, 2 May 2019 03:39:08 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:45815 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbfEBHjI (ORCPT ); Thu, 2 May 2019 03:39:08 -0400 Received: from localhost (aaubervilliers-681-1-29-145.w90-88.abo.wanadoo.fr [90.88.149.145]) (Authenticated sender: maxime.ripard@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 0FF03100019; Thu, 2 May 2019 07:39:04 +0000 (UTC) Date: Thu, 2 May 2019 09:39:04 +0200 From: Maxime Ripard To: Pablo Greco Cc: linux-sunxi@googlegroups.com, Rob Herring , Mark Rutland , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller Message-ID: <20190502073904.yng5dz5kwgulw6ha@flea> References: <1556040365-10913-1-git-send-email-pgreco@centosproject.org> <1556040365-10913-4-git-send-email-pgreco@centosproject.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d2v4zsdy3ohit6tk" Content-Disposition: inline In-Reply-To: <1556040365-10913-4-git-send-email-pgreco@centosproject.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --d2v4zsdy3ohit6tk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 23, 2019 at 02:26:00PM -0300, Pablo Greco wrote: > Just like the Bananapi M2 Ultra, the Bananapi M2 Berry has a Realtek > RTL8211E RGMII PHY tied to the GMAC. > The PMIC's DC1SW output provides power for the PHY, while the ALDO2 > output provides I/O voltages on both sides. > > Signed-off-by: Pablo Greco > --- > arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 29 +++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > index 2cb2ce0..561319b 100644 > --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > @@ -50,6 +50,7 @@ > compatible = "sinovoip,bpi-m2-berry", "allwinner,sun8i-r40"; > > aliases { > + ethernet0 = &gmac; > serial0 = &uart0; > }; > > @@ -92,6 +93,22 @@ > status = "okay"; > }; > > +&gmac { > + pinctrl-names = "default"; > + pinctrl-0 = <&gmac_rgmii_pins>; > + phy-handle = <&phy1>; > + phy-mode = "rgmii"; > + phy-supply = <®_dc1sw>; > + status = "okay"; > +}; > + > +&gmac_mdio { > + phy1: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + }; > +}; > + > &i2c0 { > status = "okay"; > > @@ -133,6 +150,12 @@ > vcc-pg-supply = <®_dldo1>; > }; > > +®_aldo2 { > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + regulator-name = "vcc-pa"; > +}; > + Shouldn't this one be added to the patch 2? Thanks Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --d2v4zsdy3ohit6tk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXMqemAAKCRDj7w1vZxhR xWdzAQC0mZNlKnsyMWKmAzQSzgvolqPbKRG2zRXlpGrUZP2jHgD9HRhKdaeZ7Bxj Qwd2WYC/jYyLYVYxMKb8LMUjXnhUIQM= =Kqmg -----END PGP SIGNATURE----- --d2v4zsdy3ohit6tk--